Skip to content

Commit 4866182

Browse files
committed
Tabs: jQuery <1.7.2 treats .data() as a getter if the value to set is undefined.
1 parent aa1e8b5 commit 4866182

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

ui/jquery.ui.tabs.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,8 @@ $.widget( "ui.tabs", {
384384
this.anchors.each(function( i, anchor ) {
385385
var selector, panel, panelId,
386386
anchorId = $( anchor ).uniqueId().attr( "id" ),
387-
tab = $( anchor ).closest( "li" );
387+
tab = $( anchor ).closest( "li" ),
388+
originalAriaControls = tab.attr( "aria-controls" );
388389

389390
// inline tab
390391
if ( isLocal( anchor ) ) {
@@ -405,12 +406,13 @@ $.widget( "ui.tabs", {
405406
if ( panel.length) {
406407
that.panels = that.panels.add( panel );
407408
}
408-
tab
409-
.data( "ui-tabs-aria-controls", tab.attr( "aria-controls" ) )
410-
.attr({
411-
"aria-controls": selector.substring( 1 ),
412-
"aria-labelledby": anchorId
413-
});
409+
if ( originalAriaControls ) {
410+
tab.data( "ui-tabs-aria-controls", originalAriaControls );
411+
}
412+
tab.attr({
413+
"aria-controls": selector.substring( 1 ),
414+
"aria-labelledby": anchorId
415+
});
414416
panel.attr( "aria-labelledby", anchorId );
415417
});
416418

0 commit comments

Comments
 (0)