Skip to content

Commit 4ac7b1f

Browse files
committed
Autocomplete: Re-add wrappers to menu items
1 parent de2ef2a commit 4ac7b1f

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

demos/autocomplete/custom-data.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
})
6969
.autocomplete( "instance" )._renderItem = function( ul, item ) {
7070
return $( "<li>" )
71-
.append( "<a>" + item.label + "<br>" + item.desc + "</a>" )
71+
.append( "<div>" + item.label + "<br>" + item.desc + "</div>" )
7272
.appendTo( ul );
7373
};
7474
});

tests/unit/autocomplete/autocomplete_core.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ test( "prevent form submit on enter when menu is active", function() {
1616
event = $.Event( "keydown" );
1717
event.keyCode = $.ui.keyCode.DOWN;
1818
element.trigger( event );
19-
equal( menu.find( ".ui-menu-item.ui-state-focus" ).length, 1, "menu item is active" );
19+
equal( menu.find( ".ui-menu-item-wrapper.ui-state-focus" ).length, 1,
20+
"menu item is active" );
2021

2122
event = $.Event( "keydown" );
2223
event.keyCode = $.ui.keyCode.ENTER;

tests/unit/autocomplete/autocomplete_options.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function autoFocusTest( afValue, focusedLength ) {
7777
open: function() {
7878
equal(
7979
element.autocomplete( "widget" )
80-
.children( ".ui-menu-item.ui-state-focus" )
80+
.find( ".ui-menu-item-wrapper.ui-state-focus" )
8181
.length,
8282
focusedLength,
8383
"first item is " + (afValue ? "" : "not") + " auto focused" );

ui/autocomplete.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,9 @@ $.widget( "ui.autocomplete", {
542542
},
543543

544544
_renderItem: function( ul, item ) {
545-
return $( "<li>" ).text( item.label ).appendTo( ul );
545+
return $( "<li>" )
546+
.append( $( "<div>" ).text( item.label ) )
547+
.appendTo( ul );
546548
},
547549

548550
_move: function( direction, event ) {

0 commit comments

Comments
 (0)