Skip to content

Commit 4c5cd20

Browse files
dekajpjzaefferer
authored andcommitted
Slider: Add missing unit test cases for values method
Closes jquerygh-1573
1 parent 1007ee8 commit 4c5cd20

File tree

1 file changed

+49
-3
lines changed

1 file changed

+49
-3
lines changed

tests/unit/slider/methods.js

Lines changed: 49 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,54 @@ test( "value", function() {
111111
equal( element.slider( "value" ), 460, "value is restricted to maximum valid step" );
112112
} );
113113

114-
//test( "values", function() {
115-
// ok(false, "missing test - untested code is broken code." );
116-
//});
114+
test( "values, single step", function() {
115+
expect( 8 );
116+
117+
var element = $( "<div></div>" ).slider( {
118+
range: false,
119+
min: 10,
120+
max: 100,
121+
step: 1,
122+
values: [ 20 ]
123+
} );
124+
125+
deepEqual( element.slider( "values" ), [ 20 ], "range: false, values - get value for handle" );
126+
equal( element.slider( "values", 0 ), 20, "values (index) - get value of handle" );
127+
128+
element.slider( "values", 0, 5 );
129+
equal( element.slider( "values", 0 ), 10, "values (index) - restrict against min" );
130+
131+
element.slider( "values", 0, 110 );
132+
equal( element.slider( "values", 0 ), 100, "values (index) - restrict against max" );
133+
134+
element.slider( "option", "range", true );
135+
element.slider( "values", [ 20, 90 ] );
136+
137+
deepEqual( element.slider( "values" ), [ 20, 90 ], "range: true, values - get value for all handles" );
138+
equal( element.slider( "values", 0 ), 20, "values (index) - 1st handle" );
139+
equal( element.slider( "values", 1 ), 90, "values (index) - 2nd handle" );
140+
141+
element.slider( "values", [ 5, 110 ] );
142+
deepEqual( element.slider( "values" ), [ 10, 100 ], "values - restricted against min and max" );
143+
element.slider( "destroy" );
144+
} );
145+
146+
test( "values, multi step", function() {
147+
expect( 2 );
148+
149+
var element = $( "<div></div>" ).slider( {
150+
range: false,
151+
min: 9,
152+
max: 20,
153+
step: 3,
154+
values: [ 9, 12 ]
155+
} );
156+
deepEqual( element.slider( "values" ), [ 9, 12 ], "values - evenly divisible by step" );
157+
158+
element.slider( "values", [ 10, 20 ] );
159+
deepEqual( element.slider( "values" ), [ 9, 18 ], "values - not evenly divisible by step" );
160+
161+
element.slider( "destroy" );
162+
} );
117163

118164
} );

0 commit comments

Comments
 (0)