clean up unused vars in grunt and tests

Author: mikesherov

.jshintrc

@@ -7,5 +7,6 @@
 	"node": true,
 	"onevar": true,
 	"trailing": true,
-	"undef": true
+	"undef": true,
+	"unused": true
 }

build/release/release.js

@@ -425,7 +425,7 @@ function abort( msg ) {
 function walk( methods ) {
 	var method = methods.shift();
 
-	function next( error ) {
+	function next( ) {
 		if ( methods.length ) {
 			walk( methods );
 		}

build/tasks/build.js

@@ -146,7 +146,7 @@ grunt.registerMultiTask( "zip", "Create a zip file for release", function() {
 		opts: {
 			cwd: 'dist'
 		}
-	}, function( err, result ) {
+	}, function( err ) {
 		if ( err ) {
 			grunt.log.error( err );
 			done();

tests/.jshintrc

@@ -11,8 +11,8 @@
 	"onevar": true,
 	"trailing": true,
 	"undef": true,
+	"unused": true,
 	"predef": [
-		"addMonths",
 		"asyncTest",
 		"container",
 		"deepEqual",
@@ -29,24 +29,14 @@
 		"Globalize",
 		"heightAfter",
 		"init",
-		"isNotOpen",
-		"isOpen",
 		"modal",
 		"module",
 		"moved",
 		"notEqual",
 		"offsetAfter",
 		"offsetBefore",
 		"ok",
-		"PROP_NAME",
 		"QUnit",
-		"restoreScroll",
-		"shouldBeDroppable",
-		"shouldmove",
-		"shouldNotBeDroppable",
-		"shouldnotmove",
-		"shouldnotresize",
-		"shouldresize",
 		"start",
 		"strictEqual",
 		"stop",

tests/unit/autocomplete/autocomplete_core.js

@@ -109,8 +109,7 @@ test( "allow form submit on enter when menu is not active", function() {
 	function arrowsMoveFocus( id, isKeyUp ) {
 		expect( 1 );
 
-		var didMove = false,
-			element = $( id ).autocomplete({
+		var element = $( id ).autocomplete({
 				source: [ "a" ],
 				delay: 0,
 				minLength: 0

tests/unit/autocomplete/autocomplete_events.js

@@ -39,7 +39,7 @@ $.each([
 						], "response ui.content" );
 						ui.content.splice( 0, 1 );
 					},
-					open: function( event ) {
+					open: function() {
 						ok( menu.is( ":visible" ), "menu open on open" );
 					},
 					focus: function( event, ui ) {
@@ -127,7 +127,7 @@ asyncTest( "cancel focus", function() {
 		element = $( "#autocomplete" ).autocomplete({
 			delay: 0,
 			source: data,
-			focus: function( event, ui ) {
+			focus: function() {
 				$( this ).val( customVal );
 				return false;
 			}
@@ -146,7 +146,7 @@ asyncTest( "cancel select", function() {
 		element = $( "#autocomplete" ).autocomplete({
 			delay: 0,
 			source: data,
-			select: function( event, ui ) {
+			select: function() {
 				$( this ).val( customVal );
 				return false;
 			}

tests/unit/autocomplete/autocomplete_options.js

@@ -33,7 +33,7 @@ function autoFocusTest( afValue, focusedLength ) {
 		autoFocus: afValue,
 		delay: 0,
 		source: data,
-		open: function( event, ui ) {
+		open: function() {
 			equal( element.autocomplete( "widget" ).children( ".ui-menu-item:first" ).find( ".ui-state-focus" ).length,
 				focusedLength, "first item is " + (afValue ? "" : "not") + " auto focused" );
 			start();

tests/unit/button/button_events.js

@@ -1,7 +1,7 @@
 /*
  * button_events.js
  */
-(function($) {
+(function() {
 
 module("button: events");
 

tests/unit/datepicker/datepicker_core.js

@@ -12,31 +12,19 @@ function equalsDate(d1, d2, message) {
 	equal(d1.toString(), d2.toString(), message);
 }
 
-function equalsDateArray(a1, a2, message) {
-	if (!a1 || !a2) {
-		ok(false, message + ' - missing dates');
-		return;
-	}
-	a1[0] = (a1[0] ? new Date(a1[0].getFullYear(), a1[0].getMonth(), a1[0].getDate()) : '');
-	a1[1] = (a1[1] ? new Date(a1[1].getFullYear(), a1[1].getMonth(), a1[1].getDate()) : '');
-	a2[0] = (a2[0] ? new Date(a2[0].getFullYear(), a2[0].getMonth(), a2[0].getDate()) : '');
-	a2[1] = (a2[1] ? new Date(a2[1].getFullYear(), a2[1].getMonth(), a2[1].getDate()) : '');
-	deepEqual(a1, a2, message);
-}
-
-function addMonths(date, offset) {
+TestHelpers.addMonths = function(date, offset) {
 	var maxDay = 32 - new Date(date.getFullYear(), date.getMonth() + offset, 32).getDate();
 	date.setDate(Math.min(date.getDate(), maxDay));
 	date.setMonth(date.getMonth() + offset);
 	return date;
-}
+};
 
 function init(id, options) {
 	$.datepicker.setDefaults($.datepicker.regional['']);
 	return $(id).datepicker($.extend({showAnim: ''}, options || {}));
 }
 
-var PROP_NAME = 'datepicker';
+TestHelpers.PROP_NAME = 'datepicker';
 
 (function($) {
 

tests/unit/datepicker/datepicker_defaults.js

@@ -2,8 +2,10 @@
  * datepicker_defaults.js
  */
 
+/*
 var datepicker_defaults = {
 	disabled: false
 };
 
-//TestHelpers.commonWidgetTests('datepicker', { defaults: datepicker_defaults });
+TestHelpers.commonWidgetTests('datepicker', { defaults: datepicker_defaults });
+*/