Skip to content

Commit 6a74bf9

Browse files
committed
Menu tests: Force line height to ensure we know how many items will be scrolled.
1 parent 1096f19 commit 6a74bf9

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

tests/unit/menu/menu.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
<style>
3232
.ui-menu {
3333
font-size: 15px;
34+
line-height: 15px;
35+
}
36+
.ui-menu .ui-menu-item {
37+
padding: 0;
3438
}
3539
#menu3 {
3640
height: 250px;

tests/unit/menu/menu_events.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -389,15 +389,15 @@ asyncTest( "handle keyboard navigation on menu with scroll and without submenus"
389389

390390
log( "keydown", true );
391391
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_DOWN } );
392-
equal( logOutput(), "keydown,11", "Keydown PAGE_DOWN" );
392+
equal( logOutput(), "keydown,17", "Keydown PAGE_DOWN" );
393393

394394
log( "keydown", true );
395395
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_DOWN } );
396-
equal( logOutput(), "keydown,22", "Keydown PAGE_DOWN" );
396+
equal( logOutput(), "keydown,34", "Keydown PAGE_DOWN" );
397397

398398
log( "keydown", true );
399399
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_UP } );
400-
equal( logOutput(), "keydown,11", "Keydown PAGE_UP" );
400+
equal( logOutput(), "keydown,17", "Keydown PAGE_UP" );
401401

402402
log( "keydown", true );
403403
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_UP } );
@@ -484,15 +484,15 @@ asyncTest( "handle keyboard navigation on menu with scroll and with submenus", f
484484
function menukeyboard3() {
485485
log( "keydown", true );
486486
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_DOWN } );
487-
equal( logOutput(), "keydown,11", "Keydown PAGE_DOWN" );
487+
equal( logOutput(), "keydown,17", "Keydown PAGE_DOWN" );
488488

489489
log( "keydown", true );
490490
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_DOWN } );
491-
equal( logOutput(), "keydown,22", "Keydown PAGE_DOWN" );
491+
equal( logOutput(), "keydown,27", "Keydown PAGE_DOWN" );
492492

493493
log( "keydown", true );
494494
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_UP } );
495-
equal( logOutput(), "keydown,11", "Keydown PAGE_UP" );
495+
equal( logOutput(), "keydown,10", "Keydown PAGE_UP" );
496496

497497
log( "keydown", true );
498498
element.simulate( "keydown", { keyCode: $.ui.keyCode.PAGE_UP } );

0 commit comments

Comments
 (0)