Skip to content

Commit 8c82edb

Browse files
committed
Tabs tests: Don't call start directly from setTimeout because Firefox <13 is dumb.
1 parent 6752994 commit 8c82edb

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

tests/unit/tabs/tabs_core.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,11 @@ asyncTest( "keyboard support - LEFT, RIGHT, UP, DOWN, HOME, END, SPACE, ENTER",
269269
equal( panels.eq( 2 ).attr( "aria-expanded" ), "false", "third panel has aria-expanded=false" );
270270
equal( panels.eq( 2 ).attr( "aria-hidden" ), "true", "third panel has aria-hidden=true" );
271271

272-
setTimeout( start, 1 );
272+
// support: Firefox 12
273+
// Firefox <13 passes arguments so we can't use setTimeout( start, 1 )
274+
setTimeout(function() {
275+
start();
276+
}, 1 );
273277
}
274278

275279
setTimeout( step1, 1 );
@@ -462,7 +466,11 @@ asyncTest( "keyboard support - CTRL navigation", function() {
462466
equal( panels.eq( 0 ).attr( "aria-expanded" ), "false", "first panel has aria-expanded=false" );
463467
equal( panels.eq( 0 ).attr( "aria-hidden" ), "true", "first panel has aria-hidden=true" );
464468

465-
setTimeout( start, 1 );
469+
// support: Firefox 12
470+
// Firefox <13 passes arguments so we can't use setTimeout( start, 1 )
471+
setTimeout(function() {
472+
start();
473+
}, 1 );
466474
}
467475

468476
setTimeout( step1, 1 );
@@ -554,7 +562,11 @@ asyncTest( "keyboard support - CTRL+UP, ALT+PAGE_DOWN, ALT+PAGE_UP", function()
554562
panels.eq( 1 ).simulate( "keydown", { keyCode: keyCode.UP, ctrlKey: true } );
555563
strictEqual( document.activeElement, tabs[ 1 ], "second tab is activeElement" );
556564

557-
setTimeout( start, 1 );
565+
// support: Firefox 12
566+
// Firefox <13 passes arguments so we can't use setTimeout( start, 1 )
567+
setTimeout(function() {
568+
start();
569+
}, 1 );
558570
}
559571

560572
setTimeout( step1, 1 );

0 commit comments

Comments
 (0)