Tests: Skip JSHint in browsers that don't support Function.prototype.bind() to work around a bug in JSHint.

scottgonzalez · scottgonzalez · commit 8eeb0e7d88a9 · 2013-11-22T11:43:55.000-05:00
diff --git a/tests/unit/testsuite.js b/tests/unit/testsuite.js
@@ -59,7 +59,9 @@ QUnit.config.urlConfig.push({
 
 jshintLoaded = false;
 TestHelpers.testJshint = function( module ) {
-	if ( QUnit.urlParams.nojshint ) {
+	// Function.prototype.bind check is needed because JSHint doesn't work in ES3 browsers anymore
+	// https://github.com/jshint/jshint/issues/1384
+	if ( QUnit.urlParams.nojshint || !Function.prototype.bind ) {
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,9 @@ QUnit.config.urlConfig.push({`
`59`	`59`
`60`	`60`	`jshintLoaded = false;`
`61`	`61`	`TestHelpers.testJshint = function( module ) {`
`62`		`- if ( QUnit.urlParams.nojshint ) {`
	`62`	`+ // Function.prototype.bind check is needed because JSHint doesn't work in ES3 browsers anymore`
	`63`	`+ // https://github.com/jshint/jshint/issues/1384`
	`64`	`+ if ( QUnit.urlParams.nojshint \|\| !Function.prototype.bind ) {`
`63`	`65`	`return;`
`64`	`66`	`}`
`65`	`67`