Skip to content

Commit 9793739

Browse files
fnagelscottgonzalez
authored andcommitted
Selectmenu: Copy title attributes
Fixes #10435 Closes jquerygh-1298
1 parent 809cc0f commit 9793739

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed

tests/unit/selectmenu/selectmenu_core.js

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,21 @@
33
module( "selectmenu: core" );
44

55
asyncTest( "accessibility", function() {
6-
var wrappers,
7-
element = $( "#speed" ).selectmenu(),
8-
button = element.selectmenu( "widget" ),
9-
menu = element.selectmenu( "menuWidget" );
6+
var wrappers, button, menu,
7+
element = $( "#speed" ).attr( "title", "A demo title" );
8+
9+
element.find( "option" ).each(function( index ) {
10+
$( this ).attr( "title", "A demo title #" + index );
11+
});
12+
13+
element.selectmenu();
14+
button = element.selectmenu( "widget" );
15+
menu = element.selectmenu( "menuWidget" );
1016

1117
button.simulate( "focus" );
1218
wrappers = menu.find( "li.ui-menu-item .ui-menu-item-wrapper" );
1319

14-
expect( 12 + wrappers.length * 2 );
20+
expect( 13 + wrappers.length * 3 );
1521

1622
setTimeout(function() {
1723
equal( button.attr( "role" ), "combobox", "button role" );
@@ -25,6 +31,7 @@ asyncTest( "accessibility", function() {
2531
"button link aria-labelledby"
2632
);
2733
equal( button.attr( "tabindex" ), 0, "button link tabindex" );
34+
equal( button.attr( "title" ), "A demo title", "button title" );
2835

2936
equal( menu.attr( "role" ), "listbox", "menu role" );
3037
equal( menu.attr( "aria-labelledby" ), button.attr( "id" ), "menu aria-labelledby" );
@@ -36,9 +43,10 @@ asyncTest( "accessibility", function() {
3643
"menu aria-activedescendant"
3744
);
3845
$.each( wrappers, function( index ) {
39-
var link = $( this );
40-
equal( link.attr( "role" ), "option", "menu link #" + index +" role" );
41-
equal( link.attr( "tabindex" ), -1, "menu link #" + index +" tabindex" );
46+
var item = $( this );
47+
equal( item.attr( "role" ), "option", "menu item #" + index +" role" );
48+
equal( item.attr( "tabindex" ), -1, "menu item #" + index +" tabindex" );
49+
equal( item.attr( "title" ), "A demo title #" + index, "menu item #" + index + " title" );
4250
});
4351
start();
4452
});

ui/selectmenu.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ return $.widget( "ui.selectmenu", {
9494
"aria-expanded": "false",
9595
"aria-autocomplete": "list",
9696
"aria-owns": this.ids.menu,
97-
"aria-haspopup": "true"
97+
"aria-haspopup": "true",
98+
title: this.element.attr( "title" )
9899
})
99100
.insertAfter( this.element );
100101

@@ -317,7 +318,9 @@ return $.widget( "ui.selectmenu", {
317318

318319
_renderItem: function( ul, item ) {
319320
var li = $( "<li>" ),
320-
wrapper = $( "<div>" );
321+
wrapper = $( "<div>", {
322+
title: item.element.attr( "title" )
323+
});
321324

322325
if ( item.disabled ) {
323326
li.addClass( "ui-state-disabled" );

0 commit comments

Comments
 (0)