Dialog: Reduce old overlay dimensions to 0x0 to avoid sizing issues. Fixes #5637 - Dialog: Dimensions of reused overlay may cause scrollbars.

scottgonzalez · scottgonzalez · commit a0f16a00b939 · 2011-05-18T09:34:50.000-04:00
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -742,7 +742,7 @@ $.extend( $.ui.dialog.overlay, {
 			$( [ document, window ] ).unbind( ".dialog-overlay" );
 		}
 
-		$el.remove();
+		$el.height( 0 ).width( 0 ).remove();
 
 		// adjust the maxZ to allow other modal dialogs to continue to work (see #4309)
 		var maxZ = 0;

Original file line number	Diff line number	Diff line change
`@@ -742,7 +742,7 @@ $.extend( $.ui.dialog.overlay, {`
`742`	`742`	`$( [ document, window ] ).unbind( ".dialog-overlay" );`
`743`	`743`	`}`
`744`	`744`
`745`		`- $el.remove();`
	`745`	`+ $el.height( 0 ).width( 0 ).remove();`
`746`	`746`
`747`	`747`	`// adjust the maxZ to allow other modal dialogs to continue to work (see #4309)`
`748`	`748`	`var maxZ = 0;`