Skip to content

Commit adcc8ef

Browse files
atomiomiscottgonzalez
authored andcommitted
Slider: Pass 0 value if slider reaches it
Fixes #12196 Closes jquerygh-1540
1 parent 0fc9bd2 commit adcc8ef

File tree

2 files changed

+27
-3
lines changed

2 files changed

+27
-3
lines changed

tests/unit/slider/events.js

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ test( "mouse based interaction part two: when handles overlap", function() {
169169
});
170170

171171
test( "event data", function() {
172-
expect( 4 );
172+
expect( 6 );
173173

174174
var slideHandleIndex = 3,
175175
values = [ 8, 9, 7, 4 ],
@@ -203,6 +203,30 @@ test( "event data", function() {
203203
});
204204

205205
handles.eq( slideHandleIndex ).simulate( "drag", { dx: 10 } );
206+
207+
element.slider( "destroy" );
208+
element = $( "#slider1" ).slider({
209+
min: 0,
210+
max: 100,
211+
value: 1,
212+
slide: function ( event, ui ) {
213+
equal( ui.value, 0, "should pass 0 value if slider reaches it" );
214+
}
215+
});
216+
handles = element.find( ".ui-slider-handle" );
217+
handles.eq( 0 ).simulate( "drag", { dx: -10 } );
218+
219+
element.slider( "destroy" );
220+
element = $( "#slider1" ).slider({
221+
min: 0,
222+
max: 100,
223+
values: [ 1, 2 ],
224+
slide: function ( event, ui ) {
225+
equal( ui.value, 0, "should pass 0 value if one of handles reaches it" );
226+
}
227+
});
228+
handles = element.find( ".ui-slider-handle" );
229+
handles.eq( 0 ).simulate( "drag", { dx: -10 } );
206230
});
207231

208232
} );

ui/slider.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,11 +301,11 @@ return $.widget( "ui.slider", $.ui.mouse, {
301301
var uiHash = {
302302
handle: this.handles[ index ],
303303
handleIndex: index,
304-
value: value || this.value()
304+
value: value !== undefined ? value : this.value()
305305
};
306306

307307
if ( this._hasMultipleValues() ) {
308-
uiHash.value = value || this.values( index );
308+
uiHash.value = value !== undefined ? value : this.values( index );
309309
uiHash.values = values || this.values();
310310
}
311311

0 commit comments

Comments
 (0)