Skip to content

Commit af1b4d8

Browse files
scottgonzalezscottgonzalez
committed
Tests: Lint.
1 parent 72a0f5c commit af1b4d8

File tree

9 files changed

+77
-74
lines changed

9 files changed

+77
-74
lines changed

‎grunt.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,8 @@ grunt.initConfig({
347347
}, defaults ),
348348
// TODO: don't create so many globals in tests
349349
globals: {
350+
accordion_equalHeights: true,
351+
accordion_setupTeardown: true,
350352
accordion_state: true,
351353
asyncTest: true,
352354
commonWidgetTests: true,

‎tests/unit/accordion/accordion_core.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ test( "handle click on header-descendant", function() {
2727
test( "accessibility", function () {
2828
expect( 37 );
2929
var element = $( "#list1" ).accordion({
30-
active: 1
31-
});
32-
var headers = element.find( ".ui-accordion-header" );
30+
active: 1
31+
}),
32+
headers = element.find( ".ui-accordion-header" );
3333

3434
equal( element.attr( "role" ), "tablist", "element role" );
3535
headers.each(function( i ) {
@@ -85,22 +85,22 @@ asyncTest( "keybaord support", function() {
8585
ok( headers.eq( 2 ).is( ".ui-state-focus" ), "RIGHT moves focus to next header" );
8686
headers.eq( 2 ).simulate( "keydown", { keyCode: keyCode.DOWN } );
8787
ok( headers.eq( 0 ).is( ".ui-state-focus" ), "DOWN wraps focus to first header" );
88-
88+
8989
headers.eq( 0 ).simulate( "keydown", { keyCode: keyCode.UP } );
9090
ok( headers.eq( 2 ).is( ".ui-state-focus" ), "UP wraps focus to last header" );
9191
headers.eq( 2 ).simulate( "keydown", { keyCode: keyCode.LEFT } );
9292
ok( headers.eq( 1 ).is( ".ui-state-focus" ), "LEFT moves focus to previous header" );
93-
93+
9494
headers.eq( 1 ).simulate( "keydown", { keyCode: keyCode.HOME } );
9595
ok( headers.eq( 0 ).is( ".ui-state-focus" ), "HOME moves focus to first header" );
9696
headers.eq( 0 ).simulate( "keydown", { keyCode: keyCode.END } );
9797
ok( headers.eq( 2 ).is( ".ui-state-focus" ), "END moves focus to last header" );
98-
98+
9999
headers.eq( 2 ).simulate( "keydown", { keyCode: keyCode.ENTER } );
100100
equal( element.accordion( "option", "active" ) , 2, "ENTER activates panel" );
101101
headers.eq( 1 ).simulate( "keydown", { keyCode: keyCode.SPACE } );
102102
equal( element.accordion( "option", "active" ), 1, "SPACE activates panel" );
103-
103+
104104
anchor.simulate( "focus" );
105105
setTimeout(function() {
106106
ok( !headers.eq( 1 ).is( ".ui-state-focus" ), "header loses focus when focusing inside the panel" );

‎tests/unit/accordion/accordion_deprecated.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ test( "{ autoHeight: true }, default", function() {
110110

111111
test( "{ autoHeight: false }", function() {
112112
expect( 3 );
113-
var element = $( "#navigation" ).accordion({ autoHeight: false });
114-
var sizes = [];
113+
var element = $( "#navigation" ).accordion({ autoHeight: false }),
114+
sizes = [];
115115
element.find( ".ui-accordion-content" ).each(function() {
116116
sizes.push( $(this).height() );
117117
});
@@ -220,7 +220,7 @@ test( "{ navigation: true, navigationFilter: header }", function() {
220220
var element = $( "#navigation" ).accordion({
221221
navigation: true,
222222
navigationFilter: function() {
223-
return /\?p=1\.1\.3$/.test( this.href );
223+
return (/\?p=1\.1\.3$/).test( this.href );
224224
}
225225
});
226226
equal( element.accordion( "option", "active" ), 2 );
@@ -232,7 +232,7 @@ test( "{ navigation: true, navigationFilter: content }", function() {
232232
var element = $( "#navigation" ).accordion({
233233
navigation: true,
234234
navigationFilter: function() {
235-
return /\?p=1\.1\.3\.2$/.test( this.href );
235+
return (/\?p=1\.1\.3\.2$/).test( this.href );
236236
}
237237
});
238238
equal( element.accordion( "option", "active" ), 2 );
@@ -248,11 +248,11 @@ module( "accordion (deprecated) - changestart/change events", accordion_setupTea
248248
test( "changestart", function() {
249249
expect( 26 );
250250
var element = $( "#list1" ).accordion({
251-
active: false,
252-
collapsible: true
253-
});
254-
var headers = element.find( ".ui-accordion-header" );
255-
var content = element.find( ".ui-accordion-content" );
251+
active: false,
252+
collapsible: true
253+
}),
254+
headers = element.find( ".ui-accordion-header" ),
255+
content = element.find( ".ui-accordion-content" );
256256

257257
element.one( "accordionchangestart", function( event, ui ) {
258258
equal( ui.oldHeader.size(), 0 );
@@ -296,11 +296,11 @@ test( "changestart", function() {
296296
test( "change", function() {
297297
expect( 20 );
298298
var element = $( "#list1" ).accordion({
299-
active: false,
300-
collapsible: true
301-
});
302-
var headers = element.find( ".ui-accordion-header" );
303-
var content = element.find( ".ui-accordion-content" );
299+
active: false,
300+
collapsible: true
301+
}),
302+
headers = element.find( ".ui-accordion-header" ),
303+
content = element.find( ".ui-accordion-content" );
304304

305305
element.one( "accordionchange", function( event, ui ) {
306306
equal( ui.oldHeader.size(), 0 );

‎tests/unit/accordion/accordion_events.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ test( "create", function() {
4444
test( "beforeActivate", function() {
4545
expect( 38 );
4646
var element = $( "#list1" ).accordion({
47-
active: false,
48-
collapsible: true
49-
});
50-
var headers = element.find( ".ui-accordion-header" );
51-
var content = element.find( ".ui-accordion-content" );
47+
active: false,
48+
collapsible: true
49+
}),
50+
headers = element.find( ".ui-accordion-header" ),
51+
content = element.find( ".ui-accordion-content" );
5252

5353
element.one( "accordionbeforeactivate", function( event, ui ) {
5454
ok( !( "originalEvent" in event ) );
@@ -109,11 +109,11 @@ test( "beforeActivate", function() {
109109
test( "activate", function() {
110110
expect( 21 );
111111
var element = $( "#list1" ).accordion({
112-
active: false,
113-
collapsible: true
114-
});
115-
var headers = element.find( ".ui-accordion-header" );
116-
var content = element.find( ".ui-accordion-content" );
112+
active: false,
113+
collapsible: true
114+
}),
115+
headers = element.find( ".ui-accordion-header" ),
116+
content = element.find( ".ui-accordion-content" );
117117

118118
element.one( "accordionactivate", function( event, ui ) {
119119
equal( ui.oldHeader.size(), 0 );

‎tests/unit/accordion/accordion_options.js

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ test( "{ animate: false }", function() {
8080
var element = $( "#list1" ).accordion({
8181
animate: false
8282
}),
83-
panels = element.find( ".ui-accordion-content" );
83+
panels = element.find( ".ui-accordion-content" ),
8484
animate = $.fn.animate;
8585
$.fn.animate = function() {
8686
ok( false, ".animate() called" );
@@ -98,7 +98,7 @@ asyncTest( "{ animate: Number }", function() {
9898
var element = $( "#list1" ).accordion({
9999
animate: 100
100100
}),
101-
panels = element.find( ".ui-accordion-content" );
101+
panels = element.find( ".ui-accordion-content" ),
102102
animate = $.fn.animate;
103103
// called twice (both panels)
104104
$.fn.animate = function( props, duration, easing ) {
@@ -120,10 +120,10 @@ asyncTest( "{ animate: Number }", function() {
120120
asyncTest( "{ animate: String }", function() {
121121
expect( 7 );
122122
var element = $( "#list1" ).accordion({
123-
animate: "linear"
124-
}),
125-
panels = element.find( ".ui-accordion-content" );
126-
animate = $.fn.animate;
123+
animate: "linear"
124+
}),
125+
panels = element.find( ".ui-accordion-content" ),
126+
animate = $.fn.animate;
127127
// called twice (both panels)
128128
$.fn.animate = function( props, duration, easing ) {
129129
equal( duration, undefined, "default duration" );
@@ -144,10 +144,10 @@ asyncTest( "{ animate: String }", function() {
144144
asyncTest( "{ animate: {} }", function() {
145145
expect( 7 );
146146
var element = $( "#list1" ).accordion({
147-
animate: {}
148-
}),
149-
panels = element.find( ".ui-accordion-content" );
150-
animate = $.fn.animate;
147+
animate: {}
148+
}),
149+
panels = element.find( ".ui-accordion-content" ),
150+
animate = $.fn.animate;
151151
// called twice (both panels)
152152
$.fn.animate = function( props, duration, easing ) {
153153
equal( duration, undefined, "default duration" );
@@ -168,10 +168,10 @@ asyncTest( "{ animate: {} }", function() {
168168
asyncTest( "{ animate: { duration, easing } }", function() {
169169
expect( 7 );
170170
var element = $( "#list1" ).accordion({
171-
animate: { duration: 100, easing: "linear" }
172-
}),
173-
panels = element.find( ".ui-accordion-content" );
174-
animate = $.fn.animate;
171+
animate: { duration: 100, easing: "linear" }
172+
}),
173+
panels = element.find( ".ui-accordion-content" ),
174+
animate = $.fn.animate;
175175
// called twice (both panels)
176176
$.fn.animate = function( props, duration, easing ) {
177177
equal( duration, 100, "correct duration" );
@@ -192,11 +192,11 @@ asyncTest( "{ animate: { duration, easing } }", function() {
192192
asyncTest( "{ animate: { duration, easing } }, animate down", function() {
193193
expect( 7 );
194194
var element = $( "#list1" ).accordion({
195-
active: 1,
196-
animate: { duration: 100, easing: "linear" }
197-
}),
198-
panels = element.find( ".ui-accordion-content" );
199-
animate = $.fn.animate;
195+
active: 1,
196+
animate: { duration: 100, easing: "linear" }
197+
}),
198+
panels = element.find( ".ui-accordion-content" ),
199+
animate = $.fn.animate;
200200
// called twice (both panels)
201201
$.fn.animate = function( props, duration, easing ) {
202202
equal( duration, 100, "correct duration" );
@@ -217,17 +217,17 @@ asyncTest( "{ animate: { duration, easing } }, animate down", function() {
217217
asyncTest( "{ animate: { duration, easing, down } }, animate down", function() {
218218
expect( 7 );
219219
var element = $( "#list1" ).accordion({
220-
active: 1,
221-
animate: {
222-
duration: 100,
223-
easing: "linear",
224-
down: {
225-
easing: "swing"
220+
active: 1,
221+
animate: {
222+
duration: 100,
223+
easing: "linear",
224+
down: {
225+
easing: "swing"
226+
}
226227
}
227-
}
228-
}),
229-
panels = element.find( ".ui-accordion-content" );
230-
animate = $.fn.animate;
228+
}),
229+
panels = element.find( ".ui-accordion-content" ),
230+
animate = $.fn.animate;
231231
// called twice (both panels)
232232
$.fn.animate = function( props, duration, easing ) {
233233
equal( duration, 100, "correct duration" );
@@ -360,10 +360,10 @@ test( "{ heightStyle: 'auto' }", function() {
360360

361361
test( "{ heightStyle: 'content' }", function() {
362362
expect( 3 );
363-
var element = $( "#navigation" ).accordion({ heightStyle: "content" });
364-
var sizes = element.find( ".ui-accordion-content" ).map(function() {
365-
return $( this ).height();
366-
}).get();
363+
var element = $( "#navigation" ).accordion({ heightStyle: "content" }),
364+
sizes = element.find( ".ui-accordion-content" ).map(function() {
365+
return $( this ).height();
366+
}).get();
367367
ok( sizes[ 0 ] >= 70 && sizes[ 0 ] <= 105, "was " + sizes[ 0 ] );
368368
ok( sizes[ 1 ] >= 98 && sizes[ 1 ] <= 126, "was " + sizes[ 1 ] );
369369
ok( sizes[ 2 ] >= 42 && sizes[ 2 ] <= 54, "was " + sizes[ 2 ] );

‎tests/unit/accordion/accordion_test_helpers.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
function accordion_state( accordion ) {
2-
var expected = $.makeArray( arguments ).slice( 1 );
3-
var actual = accordion.find( ".ui-accordion-content" ).map(function() {
2+
var expected = $.makeArray( arguments ).slice( 1 ),
3+
actual = accordion.find( ".ui-accordion-content" ).map(function() {
44
return $( this ).css( "display" ) === "none" ? 0 : 1;
55
}).get();
66
QUnit.push( QUnit.equiv(actual, expected), actual, expected );

‎tests/unit/autocomplete/autocomplete_events.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ asyncTest( "cancel search", function() {
123123

124124
asyncTest( "cancel focus", function() {
125125
expect( 1 );
126-
var customVal = "custom value";
126+
var customVal = "custom value",
127127
element = $( "#autocomplete" ).autocomplete({
128128
delay: 0,
129129
source: data,

‎tests/unit/button/button_core.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
module("button: core");
99

1010
test("checkbox", function() {
11-
var input = $("#check");
11+
var input = $("#check"),
1212
label = $("label[for=check]");
1313
ok( input.is(":visible") );
1414
ok( label.is(":not(.ui-button)") );
@@ -18,7 +18,7 @@ test("checkbox", function() {
1818
});
1919

2020
test("radios", function() {
21-
var inputs = $("#radio0 input");
21+
var inputs = $("#radio0 input"),
2222
labels = $("#radio0 label");
2323
ok( inputs.is(":visible") );
2424
ok( labels.is(":not(.ui-button)") );
@@ -51,7 +51,7 @@ test("radio groups", function() {
5151
});
5252

5353
test("input type submit, don't create child elements", function() {
54-
var input = $("#submit")
54+
var input = $("#submit");
5555
deepEqual( input.children().length, 0 );
5656
input.button();
5757
deepEqual( input.children().length, 0 );
@@ -68,11 +68,12 @@ test("buttonset", function() {
6868
});
6969

7070
test("buttonset (rtl)", function() {
71-
var parent = $("#radio1").parent();
71+
var set,
72+
parent = $("#radio1").parent();
7273
// Set to rtl
7374
parent.attr("dir", "rtl");
7475

75-
var set = $("#radio1").buttonset();
76+
set = $("#radio1").buttonset();
7677
ok( set.is(".ui-buttonset") );
7778
deepEqual( set.children(".ui-button").length, 3 );
7879
deepEqual( set.children("input:radio.ui-helper-hidden-accessible").length, 3 );

‎tests/unit/button/button_methods.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
module("button: methods");
88

99
test("destroy", function() {
10-
var beforeHtml = $("#button").parent().html();
11-
var afterHtml = $("#button").button().button("destroy").parent().html();
10+
var beforeHtml = $("#button").parent().html(),
11+
afterHtml = $("#button").button().button("destroy").parent().html();
1212
// Opera 9 outputs role="" instead of removing the attribute like everyone else
1313
if ($.browser.opera) {
1414
afterHtml = afterHtml.replace(/ role=""/g, "");

0 commit comments

Comments
 (0)