Skip to content

Commit c17f245

Browse files
committed
Autocomplete: Revert fix for #7024, broke regular menu selection.
Disabled test for now (need to reopen ticket).
1 parent 85ac420 commit c17f245

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

tests/unit/autocomplete/autocomplete_events.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ test("cancel select", function() {
203203
}, 50);
204204
});
205205

206+
/* TODO previous fix broke more than it fixed, disabling this for now - messed up regular menu select event
206207
test("blur without selection", function() {
207208
expect(1);
208209
var ac = $("#autocomplete").autocomplete({
@@ -218,5 +219,6 @@ test("blur without selection", function() {
218219
start();
219220
}, 50);
220221
});
222+
*/
221223

222224
})(jQuery);

ui/jquery.ui.autocomplete.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,6 @@ $.widget( "ui.autocomplete", {
365365
this.menu.element.hide();
366366
this.menu.blur();
367367
this._trigger( "close", event );
368-
this.menu.isNewMenu = true;
369368
}
370369
},
371370

ui/jquery.ui.menu.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var idIncrement = 0;
1818
$.widget("ui.menu", {
1919
defaultElement: "<ul>",
2020
delay: 150,
21-
isNewMenu: true,
2221
options: {
2322
position: {
2423
my: "left top",
@@ -55,8 +54,7 @@ $.widget("ui.menu", {
5554
self.select( event );
5655
})
5756
.bind( "mouseover.menu", function( event ) {
58-
if ( self.options.disabled || self.isNewMenu ) {
59-
self.isNewMenu = false;
57+
if ( self.options.disabled ) {
6058
return;
6159
}
6260
var target = $( event.target ).closest( ".ui-menu-item" );

0 commit comments

Comments
 (0)