Skip to content

Commit c9fb452

Browse files
committed
widget: Updating code for show/hide to use new effects API namespace - DRY'ed out a bit as well
1 parent 56a1b18 commit c9fb452

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

ui/jquery.ui.widget.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -365,19 +365,10 @@ $.each( { show: "fadeIn", hide: "fadeOut" }, function( method, defaultEffect ) {
365365
if (options.delay) {
366366
element.delay( options.delay );
367367
}
368-
if ( hasOptions && $.effects && $.effects[ effectName ] ) {
368+
if ( hasOptions && $.effects && $.effects.effect[ effectName ] ) {
369369
element[ method ]( options );
370-
} else if ( element[ effectName ] ) {
371-
if ( /show|hide/.test( effectName ) ) {
372-
element.queue( function() {
373-
element[ effectName ]();
374-
if ( callback ) {
375-
callback.call( element[ 0 ] );
376-
}
377-
});
378-
} else {
379-
element[ effectName ]( options.duration, options.easing, callback );
380-
}
370+
} else if ( effectName !== method && element[ effectName ] ) {
371+
element[ effectName ]( options.duration, options.easing, callback );
381372
} else {
382373
element.queue( function() {
383374
$( this )[ method ]();

0 commit comments

Comments
 (0)