Skip to content

Commit cb372b7

Browse files
committed
Popup: Make menu dependency actually optional, cleanup demos
1 parent a3866bf commit cb372b7

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

demos/popup/animation.html

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<script src="../../ui/jquery.ui.widget.js"></script>
1010
<script src="../../ui/jquery.ui.position.js"></script>
1111
<script src="../../ui/jquery.ui.button.js"></script>
12-
<script src="../../ui/jquery.ui.menu.js"></script>
1312
<script src="../../ui/jquery.effects.core.js"></script>
1413
<script src="../../ui/jquery.effects.blind.js"></script>
1514
<script src="../../ui/jquery.effects.scale.js"></script>
@@ -43,17 +42,6 @@
4342
</script>
4443
<style type="text/css">
4544
.ui-popup { position: absolute; z-index: 5000; }
46-
.ui-menu { width: 200px; }
47-
48-
/*
49-
table {
50-
border-collapse: collapse;
51-
}
52-
th, td {
53-
padding: 0.5em;
54-
border: 1px solid black;
55-
}
56-
*/
5745

5846
#login-form {
5947
width: 16em; border: 1px solid gray; border-radius: 5px;

demos/popup/default.html

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<script src="../../ui/jquery.ui.widget.js"></script>
1010
<script src="../../ui/jquery.ui.position.js"></script>
1111
<script src="../../ui/jquery.ui.button.js"></script>
12-
<script src="../../ui/jquery.ui.menu.js"></script>
1312
<script src="../../ui/jquery.ui.popup.js"></script>
1413
<script>
1514
$(function() {
@@ -28,17 +27,6 @@
2827
</script>
2928
<style type="text/css">
3029
.ui-popup { position: absolute; z-index: 5000; }
31-
.ui-menu { width: 200px; }
32-
33-
/*
34-
table {
35-
border-collapse: collapse;
36-
}
37-
th, td {
38-
padding: 0.5em;
39-
border: 1px solid black;
40-
}
41-
*/
4230

4331
#login-form {
4432
width: 16em; border: 1px solid gray; border-radius: 5px;

ui/jquery.ui.popup.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ $.widget( "ui.popup", {
8888
}
8989
});
9090

91-
if ( !this.element.is( ":ui-menu" ) ) {
92-
//default use case, wrap tab order in popup
91+
if ( !$.ui.menu || !this.element.is( ":ui-menu" ) ) {
92+
// default use case, wrap tab order in popup
9393
this._bind({ keydown : function( event ) {
9494
if ( event.keyCode !== $.ui.keyCode.TAB ) {
9595
return;
@@ -174,7 +174,8 @@ $.widget( "ui.popup", {
174174
.attr( "aria-expanded", "true" )
175175
.position( position );
176176

177-
if (this.element.is( ":ui-menu" )) { //popup is a menu
177+
// can't use custom selector when menu isn't loaded
178+
if ( $.ui.menu && this.element.is( ":ui-menu" ) ) {
178179
this.element.menu( "focus", event, this.element.children( "li" ).first() );
179180
this.element.focus();
180181
} else {

0 commit comments

Comments
 (0)