Skip to content

Commit d569b52

Browse files
committed
Effects (fade): Delegate hiding and showing to core. Fixes #8267 - dialog fadein broken since 1.9m4.
1 parent e2bbe04 commit d569b52

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

ui/jquery.effects.fade.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,16 @@
1414

1515
$.effects.effect.fade = function( o, done ) {
1616
var el = $( this ),
17-
mode = $.effects.setMode( el, o.mode || "toggle" ),
18-
hide = mode === "hide";
17+
mode = $.effects.setMode( el, o.mode || "toggle" );
1918

20-
el.show();
2119
el.animate({
22-
opacity: hide ? 0 : 1
20+
opacity: mode
2321
}, {
2422
queue: false,
2523
duration: o.duration,
2624
easing: o.easing,
27-
complete: function() {
28-
if ( hide ) {
29-
el.hide();
30-
}
31-
done();
32-
}
25+
complete: done
3326
});
3427
};
3528

36-
})(jQuery);
29+
})( jQuery );

0 commit comments

Comments
 (0)