8000 Use length property, instead of the deprecated size() method. · ProgramComputer/jquery-ui@f3b022d · GitHub
Skip to content

Commit f3b022d

Browse files
shahyarscottgonzalez
shahyar
authored and
scottgonzalez
committed
Use length property, instead of the deprecated size() method.
1 parent 9df981d commit f3b022d

File tree

8 files changed

+117
-117
lines changed

8 files changed

+117
-117
lines changed

‎tests/unit/accordion/accordion_deprecated.js‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -259,38 +259,38 @@ test( "changestart", function() {
259259
content = element.find( ".ui-accordion-content" );
260260

261261
element.one( "accordionchangestart", function( event, ui ) {
262-
equal( ui.oldHeader.size(), 0 );
263-
equal( ui.oldContent.size(), 0 );
264-
equal( ui.newHeader.size(), 1 );
262+
equal( ui.oldHeader.length, 0 );
263+
equal( ui.oldContent.length, 0 );
264+
equal( ui.newHeader.length, 1 );
265265
strictEqual( ui.newHeader[ 0 ], headers[ 0 ] );
266-
equal( ui.newContent.size(), 1 );
266+
equal( ui.newContent.length, 1 );
267267
strictEqual( ui.newContent[ 0 ], content[ 0 ] );
268268
state( element, 0, 0, 0 );
269269
});
270270
element.accordion( "option", "active", 0 );
271271
state( element, 1, 0, 0 );
272272

273273
element.one( "accordionchangestart", function( event, ui ) {
274-
equal( ui.oldHeader.size(), 1 );
274+
equal( ui.oldHeader.length, 1 );
275275
strictEqual( ui.oldHeader[ 0 ], headers[ 0 ] );
276-
equal( ui.oldContent.size(), 1 );
276+
equal( ui.oldContent.length, 1 );
277277
strictEqual( ui.oldContent[ 0 ], content[ 0 ] );
278-
equal( ui.newHeader.size(), 1 );
278+
equal( ui.newHeader.length, 1 );
279279
strictEqual( ui.newHeader[ 0 ], headers[ 1 ] );
280-
equal( ui.newContent.size(), 1 );
280+
equal( ui.newContent.length, 1 );
281281
strictEqual( ui.newContent[ 0 ], content[ 1 ] );
282282
state( element, 1, 0, 0 );
283283
});
284284
headers.eq( 1 ).click();
285285
state( element, 0, 1, 0 );
286286

287287
element.one( "accordionchangestart", function( event, ui ) {
288-
equal( ui.oldHeader.size(), 1 );
288+
equal( ui.oldHeader.length, 1 );
289289
strictEqual( ui.oldHeader[ 0 ], headers[ 1 ] );
290-
equal( ui.oldContent.size(), 1 );
290+
equal( ui.oldContent.length, 1 );
291291
strictEqual( ui.oldContent[ 0 ], content[ 1 ] );
292-
equal( ui.newHeader.size(), 0 );
293-
equal( ui.newContent.size(), 0 );
292+
equal( ui.newHeader.length, 0 );
293+
equal( ui.newContent.length, 0 );
294294
state( element, 0, 1, 0 );
295295
});
296296
element.accordion( "option", "active", false );
@@ -307,34 +307,34 @@ test( "change", function() {
307307
content = element.find( ".ui-accordion-content" );
308308

309309
element.one( "accordionchange", function( event, ui ) {
310-
equal( ui.oldHeader.size(), 0 );
311-
equal( ui.oldContent.size(), 0 );
312-
equal( ui.newHeader.size(), 1 );
310+
equal( ui.oldHeader.length, 0 );
311+
equal( ui.oldContent.length, 0 );
312+
equal( ui.newHeader.length, 1 );
313313
strictEqual( ui.newHeader[ 0 ], headers[ 0 ] );
314-
equal( ui.newContent.size(), 1 );
314+
equal( ui.newContent.length, 1 );
315315
strictEqual( ui.newContent[ 0 ], content[ 0 ] );
316316
});
317317
element.accordion( "option", "active", 0 );
318318

319319
element.one( "accordionchange", function( event, ui ) {
320-
equal( ui.oldHeader.size(), 1 );
320+
equal( ui.oldHeader.length, 1 );
321321
strictEqual( ui.oldHeader[ 0 ], headers[ 0 ] );
322-
equal( ui.oldContent.size(), 1 );
322+
equal( ui.oldContent.length, 1 );
323323
strictEqual( ui.oldContent[ 0 ], content[ 0 ] );
324-
equal( ui.newHeader.size(), 1 );
324+
equal( ui.newHeader.length, 1 );
325325
strictEqual( ui.newHeader[ 0 ], headers[ 1 ] );
326-
equal( ui.newContent.size(), 1 );
326+
equal( ui.newContent.length, 1 );
327327
strictEqual( ui.newContent[ 0 ], content[ 1 ] );
328328
});
329329
headers.eq( 1 ).click();
330330

331331
element.one( "accordionchange", function( event, ui ) {
332-
equal( ui.oldHeader.size(), 1 );
332+
equal( ui.oldHeader.length, 1 );
333333
strictEqual( ui.oldHeader[ 0 ], headers[ 1 ] );
334-
equal( ui.oldContent.size(), 1 );
334+
equal( ui.oldContent.length, 1 );
335335
strictEqual( ui.oldContent[ 0 ], content[ 1 ] );
336-
equal( ui.newHeader.size(), 0 );
337-
equal( ui.newContent.size(), 0 );
336+
equal( ui.newHeader.length, 0 );
337+
equal( ui.newContent.length, 0 );
338338
});
339339
element.accordion( "option", "active", false );
340340
});

‎tests/unit/accordion/accordion_events.js‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ test( "create", function() {
1414

1515
element.accordion({
1616
create: function( event, ui ) {
17-
equal( ui.header.size(), 1, "header size" );
17+
equal( ui.header.length, 1, "header length" );
1818
strictEqual( ui.header[ 0 ], headers[ 0 ], "header" );
19-
equal( ui.content.size(), 1, "content size" );
19+
equal( ui.content.length, 1, "content length" );
2020
strictEqual( ui.content[ 0 ], contents[ 0 ], "content" );
2121
}
2222
});
@@ -25,9 +25,9 @@ test( "create", function() {
2525
element.accordion({
2626
active: 2,
2727
create: function( event, ui ) {
28-
equal( ui.header.size(), 1, "header size" );
28+
equal( ui.header.length, 1, "header length" );
2929
strictEqual( ui.header[ 0 ], headers[ 2 ], "header" );
30-
equal( ui.content.size(), 1, "content size" );
30+
equal( ui.content.length, 1, "content length" );
3131
strictEqual( ui.content[ 0 ], contents[ 2 ], "content" );
3232
}
3333
});
@@ -37,8 +37,8 @@ test( "create", function() {
3737
active: false,
3838
collapsible: true,
3939
create: function( event, ui ) {
40-
equal( ui.header.size(), 0, "header size" );
41-
equal( ui.content.size(), 0, "content size" );
40+
equal( ui.header.length, 0, "header length" );
41+
equal( ui.content.length, 0, "content length" );
4242
}
4343
});
4444
element.accordion( "destroy" );
@@ -55,11 +55,11 @@ test( "beforeActivate", function() {
5555

5656
element.one( "accordionbeforeactivate", function( event, ui ) {
5757
ok( !( "originalEvent" in event ) );
58-
equal( ui.oldHeader.size(), 0 );
59-
equal( ui.oldContent.size(), 0 );
60-
equal( ui.newHeader.size(), 1 );
58+
equal( ui.oldHeader.length, 0 );
59+
equal( ui.oldContent.length, 0 );
60+
equal( ui.newHeader.length, 1 );
6161
strictEqual( ui.newHeader[ 0 ], headers[ 0 ] );
62-
equal( ui.newContent.size(), 1 );
62+
equal( ui.newContent.length, 1 );
6363
strictEqual( ui.newContent[ 0 ], content[ 0 ] );
6464
state( element, 0, 0, 0 );
6565
});
@@ -68,13 +68,13 @@ test( "beforeActivate", function() {
6868

6969
element.one( "accordionbeforeactivate", function( event, ui ) {
7070
equal( event.originalEvent.type, "click" );
71-
equal( ui.oldHeader.size(), 1 );
71+
equal( ui.oldHeader.length, 1 );
7272
strictEqual( ui.oldHeader[ 0 ], headers[ 0 ] );
73-
equal( ui.oldContent.size(), 1 );
73+
equal( ui.oldContent.length, 1 );
7474
strictEqual( ui.oldContent[ 0 ], content[ 0 ] );
75-
equal( ui.newHeader.size(), 1 );
75+
equal( ui.newHeader.length, 1 );
7676
strictEqual( ui.newHeader[ 0 ], headers[ 1 ] );
77-
equal( ui.newContent.size(), 1 );
77+
equal( ui.newContent.length, 1 );
7878
strictEqual( ui.newContent[ 0 ], content[ 1 ] );
7979
state( element, 1, 0, 0 );
8080
});
@@ -83,24 +83,24 @@ test( "beforeActivate", function() {
8383

8484
element.one( "accordionbeforeactivate", function( event, ui ) {
8585
ok( !( "originalEvent" in event ) );
86-
equal( ui.oldHeader.size(), 1 );
86+
equal( ui.oldHeader.length, 1 );
8787
strictEqual( ui.oldHeader[ 0 ], headers[ 1 ] );
88-
equal( ui.oldContent.size(), 1 );
88+
equal( ui.oldContent.length, 1 );
8989
strictEqual( ui.oldContent[ 0 ], content[ 1 ] );
90-
equal( ui.newHeader.size(), 0 );
91-
equal( ui.newContent.size(), 0 );
90+
equal( ui.newHeader.length, 0 );
91+
equal( ui.newContent.length, 0 );
9292
state( element, 0, 1, 0 );
9393
});
9494
element.accordion( "option", "active", false );
9595
state( element, 0, 0, 0 );
9696

9797
element.one( "accordionbeforeactivate", function( event, ui ) {
9898
ok( !( "originalEvent" in event ) );
99-
equal( ui.oldHeader.size(), 0 );
100-
equal( ui.oldContent.size(), 0 );
101-
equal( ui.newHeader.size(), 1 );
99+
equal( ui.oldHeader.length, 0 );
100+
equal( ui.oldContent.length, 0 );
101+
equal( ui.newHeader.length, 1 );
102102
strictEqual( ui.newHeader[ 0 ], headers[ 2 ] );
103-
equal( ui.newContent.size(), 1 );
103+
equal( ui.newContent.length, 1 );
104104
strictEqual( ui.newContent[ 0 ], content[ 2 ] );
105105
event.preventDefault();
106106
state( element, 0, 0, 0 );
@@ -119,34 +119,34 @@ test( "activate", function() {
119119
content = element.find( ".ui-accordion-content" );
120120

121121
element.one( "accordionactivate", function( event, ui ) {
122-
equal( ui.oldHeader.size(), 0 );
123-
equal( ui.oldContent.size(), 0 );
124-
equal( ui.newHeader.size(), 1 );
122+
equal( ui.oldHeader.length, 0 );
123+
equal( ui.oldContent.length, 0 );
124+
equal( ui.newHeader.length, 1 );
125125
strictEqual( ui.newHeader[ 0 ], headers[ 0 ] );
126-
equal( ui.newContent.size(), 1 );
126+
equal( ui.newContent.length, 1 );
127127
strictEqual( ui.newContent[ 0 ], content[ 0 ] );
128128
});
129129
element.accordion( "option", "active", 0 );
130130

131131
element.one( "accordionactivate", function( event, ui ) {
132-
equal( ui.oldHeader.size(), 1 );
132+
equal( ui.oldHeader.length, 1 );
133133
strictEqual( ui.oldHeader[ 0 ], headers[ 0 ] );
134-
equal( ui.oldContent.size(), 1 );
134+
equal( ui.oldContent.length, 1 );
135135
strictEqual( ui.oldContent[ 0 ], content[ 0 ] );
136-
equal( ui.newHeader.size(), 1 );
136+
equal( ui.newHeader.length, 1 );
137137
strictEqual( ui.newHeader[ 0 ], headers[ 1 ] );
138-
equal( ui.newContent.size(), 1 );
138+
equal( ui.newContent.length, 1 );
139139
strictEqual( ui.newContent[ 0 ], content[ 1 ] );
140140
});
141141
headers.eq( 1 ).click();
142142

143143
element.one( "accordionactivate", function( event, ui ) {
144-
equal( ui.oldHeader.size(), 1 );
144+
equal( ui.oldHeader.length, 1 );
145145
strictEqual( ui.oldHeader[ 0 ], headers[ 1 ] );
146-
equal( ui.oldContent.size(), 1 );
146+
equal( ui.oldContent.length, 1 );
147147
strictEqual( ui.oldContent[ 0 ], content[ 1 ] );
148-
equal( ui.newHeader.size(), 0 );
149-
equal( ui.newContent.size(), 0 );
148+
equal( ui.newHeader.length, 0 );
149+
equal( ui.newContent.length, 0 );
150150
});
151151
element.accordion( "option", "active", false );
152152

‎tests/unit/accordion/accordion_options.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ test( "{ active: false }", function() {
2020
collapsible: true
2121
});
2222
state( element, 0, 0, 0 );
23-
equal( element.find( ".ui-accordion-header.ui-state-active" ).size(), 0, "no headers selected" );
23+
equal( element.find( ".ui-accordion-header.ui-state-active" ).length, 0, "no headers selected" );
2424
equal( element.accordion( "option", "active" ), false );
2525

2626
element.accordion( "option", "collapsible", false );

‎tests/unit/tabs/tabs_deprecated.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ test( "selected", function() {
187187
collapsible: true
188188
});
189189
state( element, 0, 0, 0 );
190-
equal( element.find( ".ui-tabs-nav .ui-state-active" ).size(), 0, "no tabs selected" );
190+
equal( element.find( ".ui-tabs-nav .ui-state-active" ).length, 0, "no tabs selected" );
191191
strictEqual( element.tabs( "option", "selected" ), -1 );
192192

193193
element.tabs( "option", "collapsible", false );

0 commit comments

Comments
 (0)