Skip to content

Commit fb525e1

Browse files
committed
Tabs: Removed select event. Fixes #7154 - Tabs: Remove select event.
1 parent a1fd49f commit fb525e1

File tree

3 files changed

+1
-63
lines changed

3 files changed

+1
-63
lines changed

tests/unit/tabs/tabs_common_deprecated.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ TestHelpers.commonWidgetTests( "tabs", {
1919
beforeLoad: null,
2020
create: null,
2121
load: null,
22-
remove: null,
23-
select: null
22+
remove: null
2423
}
2524
});

tests/unit/tabs/tabs_deprecated.js

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -198,46 +198,6 @@ asyncTest( "load", function() {
198198
}
199199
});
200200

201-
test( "select", function() {
202-
expect( 13 );
203-
204-
var element = $( "#tabs1" ).tabs({
205-
active: false,
206-
collapsible: true
207-
}),
208-
anchors = element.find( ".ui-tabs-nav .ui-tabs-anchor" ),
209-
panels = element.find( ".ui-tabs-panel" );
210-
211-
// from collapsed
212-
element.one( "tabsselect", function( event, ui ) {
213-
ok( !( "originalEvent" in event ), "originalEvent" );
214-
strictEqual( ui.tab, anchors[ 0 ], "ui.tab" );
215-
strictEqual( ui.panel, panels[ 0 ], "ui.panel" );
216-
equal( ui.index, 0, "ui.index" );
217-
state( element, 0, 0, 0 );
218-
});
219-
element.tabs( "option", "active", 0 );
220-
state( element, 1, 0, 0 );
221-
222-
// switching tabs
223-
element.one( "tabsselect", function( event, ui ) {
224-
equal( event.originalEvent.type, "click", "originalEvent" );
225-
strictEqual( ui.tab, anchors[ 1 ], "ui.tab" );
226-
strictEqual( ui.panel, panels[ 1 ], "ui.panel" );
227-
equal( ui.index, 1, "ui.index" );
228-
state( element, 1, 0, 0 );
229-
});
230-
anchors.eq( 1 ).click();
231-
state( element, 0, 1, 0 );
232-
233-
// collapsing
234-
element.one( "tabsselect", function() {
235-
ok( false, "collapsing" );
236-
});
237-
element.tabs( "option", "active", false );
238-
state( element, 0, 0, 0 );
239-
});
240-
241201
module( "tabs (deprecated): methods" );
242202

243203
test( "add", function() {

ui/jquery.ui.tabs.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,27 +1046,6 @@ if ( $.uiBackCompat !== false ) {
10461046
}
10471047
});
10481048

1049-
// select event
1050-
$.widget( "ui.tabs", $.ui.tabs, {
1051-
options: {
1052-
select: null
1053-
},
1054-
_trigger: function( type, event, data ) {
1055-
var ret = this._superApply( arguments );
1056-
if ( !ret ) {
1057-
return false;
1058-
}
1059-
if ( type === "beforeActivate" && data.newTab.length ) {
1060-
ret = this._super( "select", event, {
1061-
tab: data.newTab.find( ".ui-tabs-anchor" )[ 0],
1062-
panel: data.newPanel[ 0 ],
1063-
index: data.newTab.closest( "li" ).index()
1064-
});
1065-
}
1066-
return ret;
1067-
}
1068-
});
1069-
10701049
// load event
10711050
$.widget( "ui.tabs", $.ui.tabs, {
10721051
_trigger: function( type, event, data ) {

0 commit comments

Comments
 (0)