Skip to content

Commit 32bce8c

Browse files
dirkschulzesvgeesus
dirkschulze
authored and
svgeesus
committed
Add reviewer comments list for CR
1 parent ec29d73 commit 32bce8c

1 file changed

Lines changed: 145 additions & 0 deletions

File tree

‎css-masking-1/issues-lc-2013.html‎

Lines changed: 145 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<title>CSS Masking Module Level 1 &ndash; disposition of comments</title>
4+
<link rel=stylesheet href="../../StyleSheets/base.css">
5+
<style type="text/css">
6+
body { font-family: sans-serif; margin: 1em }
7+
8+
table {
9+
border-collapse: collapse; margin: 1em 0; empty-cells: show;
10+
}
11+
12+
th, td {
13+
text-align: left;
14+
vertical-align: top;
15+
border: thin solid black;
16+
padding: 0.2em;
17+
}
18+
19+
pre {
20+
font-size: 0.8em;
21+
}
22+
23+
.proposal { background: orange }
24+
.rejected { background:red }
25+
26+
.source {
27+
background: silver;
28+
font-size: 1.2em;
29+
padding: 0.3em;
30+
}
31+
32+
.source a { text-decoration: none }
33+
34+
.a { background:lightgreen }
35+
.r { background:orange }
36+
.fo { background:red }
37+
</style>
38+
39+
40+
41+
<h1>CSS Masking Module Level 1 &ndash; disposition of comments</h1>
42+
43+
<p>Contents:
44+
<ul>
45+
<li><a href="#lc2013">Comments on last call of 29 October 2013</a>
46+
</ul>
47+
48+
<h2 id=lc2013>Comments on draft of 29 October 2013</h2>
49+
50+
<p>Last call
51+
document: <a href="http://www.w3.org/TR/2013/WD-css-masking-1-20131029/">
52+
http://www.w3.org/TR/2013/WD-css-masking-1-20131029/</a>.
53+
54+
<p>This document is the disposition of comments on the CSS Masking Module Level 1
55+
CR sent to the www-style, public-fx and www-svg mailing lists. The CSS Masking Module Level 1 CR was
56+
published <a href="http://www.w3.org/TR/2013/CR-css-masking-1-2013MMDD/">DD Month 2013</a>.
57+
58+
<p>The following color coding convention is used for comments:</p>
59+
60+
<ul>
61+
<li class=a>The CSS WG agreed with the reviewer.
62+
<li class=r>The CSS WG disagreed with the reviewer.
63+
<li class=fo>The CSS WG disagreed with the reviewer and the reviewer raised a Formal Objection.
64+
</ul>
65+
66+
<p>(There were no formal objections.)</p>
67+
68+
69+
<!--
70+
* security model on resource referencing (Dirk Schulze) - Added security model to specification. SVG resource fetching model will be defined by SVG Integration spec
71+
* layered masking (Dirk Schulze) - defered; to be discussed together with supporting compositing models
72+
* element selector (Brian Birtles) - different proposals to select elements in the CSS WG (GCPM, CSS UI). Defered until we resolved on a common solution.
73+
* focus ring (Dirk Schulze) -
74+
-->
75+
76+
<table>
77+
78+
<tr><th>#<th>Comment<th>Answer
79+
80+
<tr><th colspan=3 class=source><a href="http://lists.w3.org/Archives/Public/public-webappsec/2013Apr/0006.html">Move security model to CSP</a> - Comment from Dirk Schulze on Thu, 4 Apr 2013; <a href="http://www.w3.org/TR/css-masking-1/#security">solution: fixed in the spec</a>.
81+
82+
<tr><td class="r">1<td>
83+
<p>"CSS Masking and Filter Effects describe a security model for
84+
loading filter/masking/clipping resources from different origins. Speaking
85+
with some browser vendors it looks like these kind of security issues should
86+
be handled by the Content Security Policy (CSP) spec."
87+
</p>
88+
89+
<td>
90+
<p>
91+
A security model belongs to the specification. This security model was added and is part of CSS Masking Module Level 1. However, the SVG WG decided to work on a module called <a href="https://dvcs.w3.org/hg/svg2/raw-file/7a902f4a33f6/specs/integration/Overview.html">SVG Integration</a> which will define the fetching policies for SVG documents. Especially SVG documents loaded as source of further resources or as image.
92+
</p>
93+
94+
95+
<tr><th colspan=3 class=source><a href="http://lists.w3.org/Archives/Public/www-style/2013Sep/0884.html">Layered Masking</a> - Comment from Dirk Schulze on Sat, 31 Sep 2013.
96+
97+
<tr><td class="r">2<td>
98+
<p>The prefixed implementation of CSS WebKit in Safari support multiple mask layers - similar to multiple background layers for the 'background-image' property. CSS Masking should support layers as well.
99+
<p>
100+
101+
102+
<td>
103+
<p>
104+
It was unclear how authors expect mask layers to interact with each other (union, intersection, ...). Another proposal is to composite different mask layers with each other and let the authors decide which compositing mode to use. Resolution from the CSS WG: defer layered masking to a future version of the spec.
105+
</p>
106+
107+
108+
109+
110+
<tr><th colspan=3 class=source><a href="http://lists.w3.org/Archives/Public/www-svg/2012Jul/0082.html">Reference elements by selectors</a> - Comment from Brian Birtles on Mon, 23 Jul 2012.
111+
112+
<tr><td class="r">3<td>
113+
<p>Allow selecting mask and clipPath elements by CSS selectors in addition to fragment identifiers. Proposed: element(&lt;compound-selector>) function and child keyword.
114+
<p>
115+
116+
<td>
117+
<p>
118+
The specifications CSS GCPM and CSS3 UI allow element selecting. The CSS WG is investigating to find a common solution that can be used by all specifications. Element selecting deferred to a future level of the specification by editor.
119+
</p>
120+
121+
122+
123+
<tr><th colspan=3 class=source><a href="http://lists.w3.org/Archives/Public/www-style/2013Nov/0361.html">No effect of masking and clipping on focus ring</a> - Comment from Dirk Schulze on Wed, 20 Nov 2013.
124+
125+
<tr><td class="r">4<td>
126+
<p>From the minutes: "<br>
127+
krit: I would like to discuss outline property.<br>
128+
krit: Right now the spec says that every painted thing gets filtered/<br>
129+
blended.<br>
130+
krit: Turns out that outline property is also used for focus rings,<br>
131+
and that is very important a11y. For this reason, it seems not<br>
132+
useful to have the focus ring be filtered etc.<br>
133+
krit: We should masking/filters/blending not affect the focus ring."
134+
<p>
135+
136+
<td>
137+
<p>
138+
Resolution of CSS WG: Effects affect scrollbars and focus rings. We may work on controls later.
139+
</p>
140+
141+
</tr>
142+
</tbody>
143+
</table>
144+
</body>
145+
</html>

0 commit comments

Comments
 (0)