Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: leafo/scssphp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SBD580/scssphp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 2, 2013

  1. fix operator precedence bug

    first check for 'op_${opName}' and then for 'op_${ltype}_${rtype}',
    as we might want to "{color} != {color}". 
    
    This is not an optimal solution, as a way to override a general operator
    by it's arguments type is something good and not viable this way.
    SBD580 committed Apr 2, 2013
    Configuration menu
    Copy the full SHA
    84652d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2013

  1. remove "!=" operator old bug fix and add new fix

    The previous fix break the tests and was not good. This is a new one
    which just implement the op_neq_color_color method so the "!=" operator will work on colors as well
    SBD580 committed Apr 5, 2013
    Configuration menu
    Copy the full SHA
    f510f0f View commit details
    Browse the repository at this point in the history
  2. add support for "==" operator on colors

    Implement the op_eq_color_color in order to support the equality between two colors.
    In addition, fix small issue on "!=" operator when dealing with alpha value.
    SBD580 committed Apr 5, 2013
    Configuration menu
    Copy the full SHA
    901808e View commit details
    Browse the repository at this point in the history
Loading