Remove Butterknife from Project (commons-app#5660)

Author: shashankiitbhu

app/build.gradle

@@ -49,10 +49,8 @@ dependencies {
     implementation 'com.github.deano2390:MaterialShowcaseView:1.2.0'
     implementation 'com.dinuscxj:circleprogressbar:1.1.1'
     implementation 'com.karumi:dexter:5.0.0'
-    implementation "com.jakewharton:butterknife:$BUTTERKNIFE_VERSION"
     implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
 
-    kapt "com.jakewharton:butterknife-compiler:$BUTTERKNIFE_VERSION"
     implementation "com.hannesdorfmann:adapterdelegates4-kotlin-dsl-viewbinding:$ADAPTER_DELEGATES_VERSION"
     implementation "com.hannesdorfmann:adapterdelegates4-pagination:$ADAPTER_DELEGATES_VERSION"
     implementation "androidx.paging:paging-runtime-ktx:$PAGING_VERSION"

app/src/main/java/fr/free/nrw/commons/profile/leaderboard/UserDetailAdapter.java

@@ -11,7 +11,6 @@
 import android.widget.Toast;
 import androidx.annotation.NonNull;
 import androidx.recyclerview.widget.RecyclerView;
-import butterknife.internal.DebouncingOnClickListener;
 import com.facebook.drawee.view.SimpleDraweeView;
 import fr.free.nrw.commons.BuildConfig;
 import fr.free.nrw.commons.R;
@@ -108,9 +107,10 @@ public void onBindViewHolder(@NonNull UserDetailAdapter.DataViewHolder holder, i
         }
         if (currentlyLoggedInUserName != null && currentlyLoggedInUserName.equals(
             leaderboardResponse.getUsername())) {
-            avatar.setOnClickListener(new DebouncingOnClickListener() {
+
+            avatar.setOnClickListener(new View.OnClickListener() {
                 @Override
-                public void doClick(View v) {
+                public void onClick(View v) {
                     Toast.makeText(v.getContext(),
                         R.string.set_up_avatar_toast_string,
                         Toast.LENGTH_LONG).show();

app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java

@@ -29,7 +29,6 @@
 import androidx.viewpager.widget.PagerAdapter;
 import androidx.viewpager.widget.ViewPager;
 import androidx.work.ExistingWorkPolicy;
-import butterknife.OnClick;
 import fr.free.nrw.commons.CommonsApplication;
 import fr.free.nrw.commons.R;
 import fr.free.nrw.commons.auth.LoginActivity;
@@ -170,6 +169,7 @@ protected void onCreate(Bundle savedInstanceState) {
 
         compositeDisposable = new CompositeDisposable();
         init();
+        binding.rlContainerTitle.setOnClickListener(v -> onRlContainerTitleClicked());
         nearbyPopupAnswers = new HashMap<>();
         //getting the current dpi of the device and if it is less than 320dp i.e. overlapping
         //threshold, thumbnails automatically minimizes
@@ -872,7 +872,7 @@ public int getItemPosition(Object object) {
     }
 
 
-    @OnClick(R.id.rl_container_title)
+
     public void onRlContainerTitleClicked() {
         binding.rvThumbnails.setVisibility(isTitleExpanded ? View.GONE : View.VISIBLE);
         isTitleExpanded = !isTitleExpanded;

gradle.properties

@@ -18,7 +18,6 @@ org.gradle.caching=true
 android.enableR8.fullMode=false
 
 KOTLIN_VERSION=1.7.20
-BUTTERKNIFE_VERSION=10.1.0
 LEAK_CANARY_VERSION=2.10
 DAGGER_VERSION=2.23
 ROOM_VERSION=2.5.0