Skip to content

Commit 8f80a4e

Browse files
Update Software-design-document.md
1 parent f81597f commit 8f80a4e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

android/Software-design-document.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ When user types in search field, display:
1919

2020
## Upload flow
2121
* Copy the image to the cache folder.
22-
* Remove the EXIF data of the cached image.
22+
* Remove the EXIF data of the cached image, depending on the settings in `Settings`>`Manage EXIF Tags`.
2323
* Upload the image to the server.
2424
* Delete the cached image.
2525

26-
Removing the EXIF data of the image is important as image might contain some personal information (User name, camera specifications etc) as its metadata. Furthermore, there is an [API](https://github.com/commons-app/apps-android-commons/issues/175#issue-164989234) that checks for the image in Commons server using the SHA1 of the image. Deleting EXIF data from an image changes the SHA1 of the image thus checking for an image in the server requires you to gennerate SHA1 of the modified (EXIF removed) image.
26+
Removing the EXIF data of the image is important as image might contain some personal information (author, camera model, serial numbers, etc) as its metadata. Furthermore, there is an [API](https://github.com/commons-app/apps-android-commons/issues/175#issue-164989234) that checks for the image in Commons server using the SHA1 of the image. Deleting EXIF data from an image changes the SHA1 of the image thus checking for an image in the server requires you to gennerate SHA1 of the modified (EXIF similarly removed) image.

0 commit comments

Comments
 (0)