Skip to content

Commit d9c9fc4

Browse files
author
Gabriel Schulhof
committed
Forms: Unbind from pageshow to stop reset test calling start() twice
1 parent 87f9f48 commit d9c9fc4

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

tests/integration/forms/forms_core.js

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -176,26 +176,28 @@ asyncTest( "Form resets correctly", function() {
176176
wentToTestPage = true;
177177
$( "#goToTestPage" ).click();
178178
}
179-
};
180-
181-
$( document ).bind( "pageshow", function( e ) {
182-
if ( e.target.id === "testPage" ) {
183-
setTimeout( function() {
184-
runTest( e.target, function() {
185-
testComplete = true;
186-
setTimeout( function() { $( "#goToStartPage" ).click(); } );
179+
},
180+
handlePageShow = function( e ) {
181+
if ( e.target.id === "testPage" ) {
182+
setTimeout( function() {
183+
runTest( e.target, function() {
184+
testComplete = true;
185+
setTimeout( function() { $( "#goToStartPage" ).click(); } );
186+
});
187187
});
188-
});
189-
} else if ( e.target.id === "startPage" ) {
190-
if ( wentToTestPage ) {
191-
if ( testComplete ) {
192-
start();
188+
} else if ( e.target.id === "startPage" ) {
189+
if ( wentToTestPage ) {
190+
if ( testComplete ) {
191+
$( document ).unbind( "pageshow", handlePageShow );
192+
start();
193+
}
194+
} else {
195+
setTimeout( maybeGoToTestPage );
193196
}
194-
} else {
195-
setTimeout( maybeGoToTestPage );
196197
}
197198
}
198-
});
199+
200+
$( document ).bind( "pageshow", handlePageShow );
199201

200202
setTimeout( maybeGoToTestPage );
201203
});

0 commit comments

Comments
 (0)