Merge pull request rails#398 from krzychk/formactions

Add support for "formaction" and "formmethod" attributes in remote forms

Author: rafaelfranca

src/rails.js

@@ -113,15 +113,17 @@
         dataType = element.data('type') || ($.ajaxSettings && $.ajaxSettings.dataType);
 
         if (element.is('form')) {
-          method = element.attr('method');
-          url = element.attr('action');
+          method = element.data('ujs:submit-button-formmethod') || element.attr('method');
+          url = element.data('ujs:submit-button-formaction') || element.attr('action');
           data = $(element[0].elements).serializeArray();
           // memoized value from clicked submit button
           var button = element.data('ujs:submit-button');
           if (button) {
             data.push(button);
             element.data('ujs:submit-button', null);
           }
+          element.data('ujs:submit-button-formmethod', null)
+          element.data('ujs:submit-button-formaction', null)
         } else if (element.is(rails.inputChangeSelector)) {
           method = element.data('method');
           url = element.data('url');
@@ -510,8 +512,10 @@
       }
       form.data('ujs:submit-button', data);
 
-      // Save formnovalidate attribute from button
+      // Save attributes from button
       form.data('ujs:formnovalidate-button', button.attr('formnovalidate'));
+      form.data('ujs:submit-button-formaction', button.attr('formaction'))
+      form.data('ujs:submit-button-formmethod', button.attr('formmethod'));
     });
 
     $document.delegate(rails.formSubmitSelector, 'ajax:send.rails', function(event) {

test/public/test/call-remote.js

@@ -32,6 +32,19 @@ asyncTest('form method is not read from "data-method" attribute in case of missi
   });
 });
 
+asyncTest('form method is read from submit button "formmethod" if submit is triggered by that button', 1, function() {
+  var submitButton = $('<input type="submit" formmethod="get">')
+  buildForm({ method: 'post' });
+
+  $('#qunit-fixture').find('form').append(submitButton)
+    .bind('ajax:success', function(e, data, status, xhr) {
+      App.assertGetRequest(data);
+    })
+    .bind('ajax:complete', function() { start() });
+
+  submitButton.trigger('click');
+});
+
 asyncTest('form default method is GET', 1, function() {
   buildForm();
 
@@ -56,6 +69,19 @@ asyncTest('form url is read from "action" not "href"', 1, function() {
   });
 });
 
+asyncTest('form url is read from submit button "formaction" if submit is triggered by that button', 1, function() {
+  var submitButton = $('<input type="submit" formaction="/echo">')
+  buildForm({ method: 'post', href: '/echo2' });
+
+  $('#qunit-fixture').find('form').append(submitButton)
+    .bind('ajax:success', function(e, data, status, xhr) {
+      App.assertRequestPath(data, '/echo');
+    })
+    .bind('ajax:complete', function() { start() });
+
+  submitButton.trigger('click');
+});
+
 asyncTest('prefer JS, but accept any format', 1, function() {
   buildForm({ method: 'post' });