Skip to content

Commit bf17e1e

Browse files
authored
Merge pull request creativecommons#47 from creativecommons/add_browser_requirements
Added list of browsers required to be supported to code guidelines.
2 parents 3fdfbd1 + 9e906c9 commit bf17e1e

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

content/contributing-code/contents.lr

+8-1
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,20 @@ When in doubt, ask a question on [one of our community forums](/community).
5252
* Describe how you tested your change.
5353
* If a reviewer is not assigned automatically, manually [request a review](https://help.github.com/en/articles/requesting-a-pull-request-review) from either the repository maintainer (if you have that information) or `@creativecommons/engineering`.
5454

55-
### Code
55+
### Code guidelines
5656

5757
* Write comprehensive and robust tests that cover the changes you've made in your work.
5858
* Follow the appropriate code style standards for the language and framework you're using (e.g. PEP 8 for Python).
5959
* Write readable code – keep functions small and modular and name variables descriptively.
6060
* Document your code thoroughly.
6161
* Make sure all the existing tests pass.
62+
* User-facing code should support the following browsers:
63+
* Chrome (Webkit-Blink / 22+)
64+
* Firefox (Gecko / 28+)
65+
* Edge (Chromium based / 12+)
66+
* Opera (Chromium-Blink / 12.1+)
67+
* Safari (Apple’s Webkit / 7+)
68+
* IE 11 (Trident)
6269

6370
## New projects
6471

0 commit comments

Comments
 (0)