Skip to content

Commit c6bf2d0

Browse files
authored
Merge pull request #12 from UdashFramework/jq-3
Upgrade to jQuery 3.2.1
2 parents d4200c6 + 33226e1 commit c6bf2d0

File tree

16 files changed

+220
-487
lines changed

16 files changed

+220
-487
lines changed

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ dist: trusty
33

44
jdk: oraclejdk8
55
scala:
6-
- 2.11.8
7-
- 2.12.1
6+
- 2.11.11
7+
- 2.12.2
88

99
before_script:
1010
- "export DISPLAY=:99.0"
@@ -24,4 +24,4 @@ before_script:
2424
script:
2525
- sbt ++$TRAVIS_SCALA_VERSION "set (jsEnv in Test := new org.scalajs.jsenv.selenium.SeleniumJSEnv(org.scalajs.jsenv.selenium.Chrome))" test
2626
- sbt ++$TRAVIS_SCALA_VERSION publishLocal
27-
# - cd example && sbt ++$TRAVIS_SCALA_VERSION compile
27+
- cd example && sbt ++$TRAVIS_SCALA_VERSION compile

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Static types for the jQuery API for [Scala.js](http://www.scala-js.org/) program
77
Add the following to your SBT build:
88

99
```scala
10-
libraryDependencies += "io.udash" %%% "udash-jquery" % "1.0.0"
10+
libraryDependencies += "io.udash" %%% "udash-jquery" % "1.1.0"
1111
```
1212

1313
then import the jQuery package:

build.sbt

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11

22
name := "udash-jquery"
33

4-
version := "1.0.1"
4+
version := "1.1.0"
55
organization := "io.udash"
6-
scalaVersion := "2.12.1"
7-
crossScalaVersions := Seq("2.11.8", "2.12.1")
6+
scalaVersion := "2.12.2"
7+
crossScalaVersions := Seq("2.11.11", "2.12.2")
88
scalacOptions in ThisBuild ++= Seq(
99
"-feature",
1010
"-deprecation",
@@ -14,23 +14,24 @@ scalacOptions in ThisBuild ++= Seq(
1414
"-language:dynamics",
1515
"-Xfuture",
1616
"-Xfatal-warnings",
17-
"-Xlint:_,-missing-interpolator,-adapted-args"
17+
CrossVersion.partialVersion(scalaVersion.value).collect {
18+
// WORKAROUND https://github.com/scala/scala/pull/5402
19+
case (2, 12) => "-Xlint:-unused,_"
20+
}.getOrElse("-Xlint:_")
1821
)
1922

20-
jsEnv in Test := new org.scalajs.jsenv.selenium.SeleniumJSEnv(org.scalajs.jsenv.selenium.Firefox)
23+
jsEnv in Test := new org.scalajs.jsenv.selenium.SeleniumJSEnv(org.scalajs.jsenv.selenium.Firefox())
2124

2225
libraryDependencies ++= Seq(
23-
"org.scala-js" %%% "scalajs-dom" % "0.9.1",
24-
"org.scalatest" %%% "scalatest" % "3.0.1" % Test,
25-
"com.lihaoyi" %%% "scalatags" % "0.6.2" % Test
26+
"org.scala-js" %%% "scalajs-dom" % "0.9.2",
27+
"org.scalatest" %%% "scalatest" % "3.0.3" % Test,
28+
"com.lihaoyi" %%% "scalatags" % "0.6.5" % Test
2629
)
2730

2831
jsDependencies +=
29-
"org.webjars" % "jquery" % "2.2.4" / "2.2.4/jquery.js" minified "2.2.4/jquery.min.js"
32+
"org.webjars" % "jquery" % "3.2.1" / "3.2.1/jquery.js" minified "3.2.1/jquery.min.js"
3033

3134
requiresDOM in Test := true
32-
persistLauncher in Test := false
33-
scalaJSUseRhino in Test := false
3435

3536
lazy val root = project.in(file("."))
3637
.enablePlugins(ScalaJSPlugin)

example/build.sbt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1+
import UdashBuild._
2+
import Dependencies._
3+
14
name := "jquery-demo"
25

3-
version in ThisBuild := "1.0.1-SNAPSHOT"
4-
scalaVersion in ThisBuild := "2.11.8"
6+
version in ThisBuild := "1.1.0"
7+
scalaVersion in ThisBuild := "2.12.2"
58
organization in ThisBuild := "io.udash"
69
crossPaths in ThisBuild := false
710
scalacOptions in ThisBuild ++= Seq(
@@ -12,37 +15,34 @@ scalacOptions in ThisBuild ++= Seq(
1215
"-language:existentials",
1316
"-language:dynamics",
1417
"-Xfuture",
15-
"-Xfatal-warnings",
16-
"-Xlint:_,-missing-interpolator,-adapted-args"
18+
"-Xfatal-warnings"
1719
)
1820

1921
val generatedDir = file("generated")
2022
val `jquery-demo` = project.in(file(".")).enablePlugins(ScalaJSPlugin)
2123
.settings(
2224
libraryDependencies ++= deps.value,
23-
persistLauncher in Compile := true,
2425

2526
/* move these files out of target/. */
2627
crossTarget in (Compile, fullOptJS) := generatedDir,
2728
crossTarget in (Compile, fastOptJS) := generatedDir,
2829
crossTarget in (Compile, packageJSDependencies) := generatedDir,
29-
crossTarget in (Compile, packageScalaJSLauncher) := generatedDir,
3030
crossTarget in (Compile, packageMinifiedJSDependencies) := generatedDir,
3131

32-
compile <<= (compile in Compile).dependsOn(compileStatics),
32+
compile := (compile in Compile).dependsOn(compileStatics).value,
3333
compileStatics := {
3434
compileStaticsForRelease.value
3535
(crossTarget.value / StaticFilesDir).***.get
3636
},
3737

38+
scalaJSUseMainModuleInitializer := true,
39+
3840
artifactPath in(Compile, fastOptJS) :=
3941
(crossTarget in(Compile, fastOptJS)).value / StaticFilesDir / WebContent / "scripts" / "frontend-impl-fast.js",
4042
artifactPath in(Compile, fullOptJS) :=
4143
(crossTarget in(Compile, fullOptJS)).value / StaticFilesDir / WebContent / "scripts" / "frontend-impl.js",
4244
artifactPath in(Compile, packageJSDependencies) :=
4345
(crossTarget in(Compile, packageJSDependencies)).value / StaticFilesDir / WebContent / "scripts" / "frontend-deps-fast.js",
4446
artifactPath in(Compile, packageMinifiedJSDependencies) :=
45-
(crossTarget in(Compile, packageMinifiedJSDependencies)).value / StaticFilesDir / WebContent / "scripts" / "frontend-deps.js",
46-
artifactPath in(Compile, packageScalaJSLauncher) :=
47-
(crossTarget in(Compile, packageScalaJSLauncher)).value / StaticFilesDir / WebContent / "scripts" / "frontend-init.js"
47+
(crossTarget in(Compile, packageMinifiedJSDependencies)).value / StaticFilesDir / WebContent / "scripts" / "frontend-deps.js"
4848
)

example/project/Dependencies.scala

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
import org.scalajs.sbtplugin.ScalaJSPlugin.autoImport._
22
import sbt._
33

4-
object Dependencies extends Build {
5-
val udashCoreVersion = "0.4.0"
6-
val udashJQueryVersion = "1.0.1"
4+
object Dependencies {
5+
val udashCoreVersion = "0.5.0"
6+
val udashJQueryVersion = "1.1.0"
77

88
val deps = Def.setting(Seq[ModuleID](
99
"io.udash" %%% "udash-core-frontend" % udashCoreVersion,
1010
"io.udash" %%% "udash-jquery" % udashJQueryVersion
1111
))
12-
13-
val depsJS = Def.setting(Seq[org.scalajs.sbtplugin.JSModuleID](
14-
))
1512
}

example/project/UdashBuild.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import org.scalajs.sbtplugin.ScalaJSPlugin.AutoImport._
22
import sbt.Keys._
33
import sbt._
44

5-
object UdashBuild extends Build {
5+
object UdashBuild {
66
val StaticFilesDir = "UdashStatic"
77
val WebContent = "WebContent"
88

example/project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version = 0.13.13
1+
sbt.version = 0.13.15

example/project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
logLevel := Level.Warn
2-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.13")
2+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")

example/src/main/assets/index.dev.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
<script src="scripts/frontend-deps-fast.js"></script>
88
<script src="scripts/frontend-impl-fast.js"></script>
9-
<script src="scripts/frontend-init.js"></script>
109

1110
</head>
1211
<body>

example/src/main/assets/index.prod.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
<script src="scripts/frontend-deps.js"></script>
88
<script src="scripts/frontend-impl.js"></script>
9-
<script src="scripts/frontend-init.js"></script>
109

1110
</head>
1211
<body>

example/src/main/scala/io/udash/demos/jquery/init.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ object Context {
1616
implicit val applicationInstance = new Application[RoutingState](routingRegistry, viewPresenterRegistry, RootState)
1717
}
1818

19-
object Init extends JSApp {
19+
object Init {
2020
import Context._
2121

2222
@JSExport
23-
override def main(): Unit = {
24-
jQ(document).ready((_: Element) => {
23+
def main(args: Array[String]): Unit = {
24+
jQ((_: Element) => {
2525
val appRoot = jQ("#application").get(0)
2626
if (appRoot.isEmpty) {
2727
dom.console.error("Application root element not found! Check you index.html file!")

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version = 0.13.13
1+
sbt.version = 0.13.15

project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
logLevel := Level.Warn
22

3-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.13")
3+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
44

55
libraryDependencies += "org.scala-js" %% "scalajs-env-selenium" % "0.1.3"

0 commit comments

Comments
 (0)