Fix the handling of call traces for exceptions of native functions

Due to the multiple prototypes being tried in chain, native functions
are throwing errors even in valid code, which will be swallowed when
finding a compatible prototype. In case of failure, the catched
exception message is sent back to the throwError API. This has 2
effects:

- due to the double usage of throwError, the details about the location
  and call trace get duplicated in the final message
- computing the call trace message is very costly due to the size of the
  call trace. Computing it for exceptions which will be swallowed is an
  useless performance hit.

Places catching exceptions are now toggling a flag which tells
throwError to skip adding the details. This avoids both the performance
hit of multiple prototypes and the duplicated details (as the first call
to throwError is now done with the flag toggled).

Author: stof

src/Compiler.php

@@ -161,6 +161,7 @@ class Compiler
     protected $stderr;
     protected $shouldEvaluate;
     protected $ignoreErrors;
+    protected $ignoreCallStackMessage = false;
 
     protected $callStack = [];
 
@@ -255,6 +256,7 @@ public function compile($code, $path = null)
         $this->storeEnv       = null;
         $this->charsetSeen    = null;
         $this->shouldEvaluate = null;
+        $this->ignoreCallStackMessage = false;
 
         $this->parser = $this->parserFactory($path);
         $tree         = $this->parser->parse($code);
@@ -1564,11 +1566,14 @@ protected function compileCommentValue($value, $pushEnv = false)
                 $this->pushEnv();
             }
 
+            $ignoreCallStackMessage = $this->ignoreCallStackMessage;
+            $this->ignoreCallStackMessage = true;
             try {
                 $c = $this->compileValue($value[2]);
             } catch (\Exception $e) {
                 // ignore error in comment compilation which are only interpolation
             }
+            $this->ignoreCallStackMessage = $ignoreCallStackMessage;
 
             if ($pushEnv) {
                 $this->popEnv();
@@ -4737,23 +4742,25 @@ public function throwError($msg)
             return;
         }
 
-        $line   = $this->sourceLine;
-        $column = $this->sourceColumn;
-
-        $loc = isset($this->sourceNames[$this->sourceIndex])
-             ? $this->sourceNames[$this->sourceIndex] . " on line $line, at column $column"
-             : "line: $line, column: $column";
-
         if (func_num_args() > 1) {
             $msg = call_user_func_array('sprintf', func_get_args());
         }
 
-        $msg = "$msg: $loc";
+        if (!$this->ignoreCallStackMessage) {
+            $line   = $this->sourceLine;
+            $column = $this->sourceColumn;
+
+            $loc = isset($this->sourceNames[$this->sourceIndex])
+                ? $this->sourceNames[$this->sourceIndex] . " on line $line, at column $column"
+                : "line: $line, column: $column";
 
-        $callStackMsg = $this->callStackMessage();
+            $msg = "$msg: $loc";
 
-        if ($callStackMsg) {
-            $msg .= "\nCall Stack:\n" . $callStackMsg;
+            $callStackMsg = $this->callStackMessage();
+
+            if ($callStackMsg) {
+                $msg .= "\nCall Stack:\n" . $callStackMsg;
+            }
         }
 
         throw new CompilerException($msg);
@@ -5026,6 +5033,9 @@ protected function sortNativeFunctionArgs($functionName, $prototypes, $args)
                 $argDef[] = [$name, $default, $isVariable];
             }
 
+            $ignoreCallStackMessage = $this->ignoreCallStackMessage;
+            $this->ignoreCallStackMessage = true;
+
             try {
                 $vars = $this->applyArguments($argDef, $args, false, false);
 
@@ -5063,6 +5073,7 @@ protected function sortNativeFunctionArgs($functionName, $prototypes, $args)
             } catch (CompilerException $e) {
                 $exceptionMessage = $e->getMessage();
             }
+            $this->ignoreCallStackMessage = $ignoreCallStackMessage;
         }
 
         if ($exceptionMessage && ! $prototypeHasMatch) {