Skip to content

Commit acd5911

Browse files
committed
updates from review.
1 parent 4512ac0 commit acd5911

File tree

1 file changed

+20
-23
lines changed

1 file changed

+20
-23
lines changed

css-display-4/Overview.bs

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,7 @@ Reading Order: the 'reading-order-items' property</h2>
11531153

11541154
<pre class='propdef'>
11551155
Name: reading-order-items
1156-
Value: normal from-order? | flex [ visual | flow ] | grid [ rows | columns ]
1156+
Value: normal | flex-visual | flex-flow | grid-rows | grid-columns | grid-order
11571157
Initial: normal
11581158
Applies to: flex and grid containers
11591159
Inherited: no
@@ -1165,47 +1165,44 @@ Reading Order: the 'reading-order-items' property</h2>
11651165
elements in a flex or grid layout are rendered to speech
11661166
or are navigated to when using (linear) sequential navigation methods.
11671167

1168-
It takes one or more keyword values. Values are defined as follows:
1168+
It takes one keyword value. Values are defined as follows:
11691169

11701170
<dl dfn-for=reading-order-items dfn-type=value>
11711171
<dt><dfn>normal</dfn>
11721172
<dd>
11731173
Follow the order of elements in the DOM.
1174-
<dt><dfn>normal from-order</dfn>
1175-
<dd>
1176-
Follows the [=order-modified document order=].
1177-
Therefore, as 'normal' unless the 'order'
1178-
property has been used to change the order of items.
1179-
<dt><dfn>flex visual</dfn>
1174+
<dt><dfn>flex-visual</dfn>
11801175
<dd>
11811176
Only takes effect on flex containers.
11821177
Follows the visual reading order of flex items,
11831178
taking the writing mode into account.
11841179
Therefore, a document in English, with a 'flex-direction' of 'row-reverse'
11851180
and 'reading-order-items' of 'flex visual'
11861181
would have a reading order of left to right.
1187-
<dt><dfn>flex flow</dfn>
1182+
<dt><dfn>flex-flow</dfn>
11881183
<dd>
11891184
Only takes effect on flex containers.
11901185
Follows the 'flex-flow' direction.
1191-
<dt><dfn>grid rows</dfn>
1186+
<dt><dfn>grid-rows</dfn>
11921187
<dd>
11931188
Only takes effect on grid containers.
11941189
Follows the visual order of grid items by row,
11951190
taking the writing mode into account.
1196-
<dt><dfn>grid columns</dfn>
1191+
<dt><dfn>grid-columns</dfn>
11971192
<dd>
11981193
Only takes effect on grid containers.
11991194
Follows the visual order of grid items by column,
12001195
taking the writing mode into account.
1196+
<dt><dfn>grid-order</dfn>
1197+
<dd>
1198+
Follows the [=order-modified document order=].
1199+
Therefore, as 'normal' unless the 'order'
1200+
property has been used to change the order of items.
12011201
</dl>
12021202

1203-
ISSUE: <a href="https://github.com/w3c/csswg-drafts/issues/8589#issuecomment-1690330738">As raised in a comment by fantasai</a>,
1204-
do we need the multiple keywords, or should we hyphenate?
1205-
12061203
<div class='example'>
12071204
In this example, there are three flex items displayed as a row,
1208-
The 'reading-order-items' property has a value of 'flex visual'.
1205+
The 'reading-order-items' property has a value of 'flex-visual'.
12091206
The 'flex-direction' property is 'row-reverse'.
12101207
The reading order of these items is therefore
12111208
"Item 3", "Item 2", "Item 1", reading from left to right.
@@ -1222,15 +1219,15 @@ Reading Order: the 'reading-order-items' property</h2>
12221219
.wrapper {
12231220
display: flex;
12241221
flex-direction: row-reverse;
1225-
reading-order-items: flex visual;
1222+
reading-order-items: flex-visual;
12261223
}
12271224
</pre>
12281225
</div>
12291226

12301227
<div class='example'>
12311228
In this example there are four grid items,
12321229
placed on a grid and displayed visually out of DOM order.
1233-
The 'reading-order-items' property has a value of 'grid rows',
1230+
The 'reading-order-items' property has a value of 'grid-rows',
12341231
and the document is in English.
12351232
The reading order of these items is therefore
12361233
"Item 4", "Item 2", "Item 3", "Item 1".
@@ -1250,7 +1247,7 @@ Reading Order: the 'reading-order-items' property</h2>
12501247
grid-template-columns: repeat(3, 150px);
12511248
grid-template-areas: "d b b"
12521249
"c c a";
1253-
reading-order-items: grid rows;
1250+
reading-order-items: grid-rows;
12541251
}
12551252

12561253
.a { grid-area: a; }
@@ -1263,12 +1260,12 @@ Reading Order: the 'reading-order-items' property</h2>
12631260
The 'reading-order-items' property affects neither layout nor painting order
12641261
and therefore has no effect on rendering to the visual [=canvas=].
12651262

1266-
When using a 'flex' or 'grid' keyword value,
1263+
When using a 'flex-*' or 'grid-*' keyword value,
12671264
the 'order' property is taken into account.
12681265

12691266
<div class='example'>
12701267
In this example, there are three flex items displayed as a row,
1271-
The 'reading-order-items' property has a value of 'flex flow'.
1268+
The 'reading-order-items' property has a value of 'flex-flow'.
12721269
The third item in the DOM has 'order=-1'.
12731270
The reading order of these items is therefore
12741271
"Item 3", "Item 1", "Item 2".
@@ -1288,7 +1285,7 @@ Reading Order: the 'reading-order-items' property</h2>
12881285

12891286
.wrapper {
12901287
display: flex;
1291-
reading-order-items: flex flow;
1288+
reading-order-items: flex-flow;
12921289
}
12931290
</pre>
12941291
</div>
@@ -2144,8 +2141,8 @@ Additions since Level 3</h3>
21442141

21452142
The following features were added since <a href="https://www.w3.org/TR/css-display-3/">CSS Display Module Level 3</a>:
21462143

2147-
* the 'layout-order' and 'reading-order' [=longhand properties=] of 'order'
2148-
(<a href="https://github.com/w3c/csswg-drafts/issues/7387#issuecomment-1217193918">Issue 7387</a>)
2144+
* the 'reading-order-items' property
2145+
(<a href="https://github.com/w3c/csswg-drafts/issues/8589#issuecomment-1721504153">Issue 8589</a>)
21492146
* the ability to animate 'display'
21502147

21512148
<h2 id="priv" class="no-num">

0 commit comments

Comments
 (0)