Skip to content

Commit 22169e6

Browse files
committed
Prefer border: 0 over border: none
Although the scss-lint configuration file here enforced `border: none`, we chatted about it and agreed that we prefer `border: 0`.
1 parent 807a755 commit 22169e6

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

.scss-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ linters:
22

33
BorderZero:
44
enabled: true
5-
convention: none
5+
convention: zero
66

77
BemDepth:
88
enabled: true

README.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
- [OOCSS and BEM](#oocss-and-bem)
1515
- [ID Selectors](#id-selectors)
1616
- [JavaScript hooks](#javascript-hooks)
17+
- [Border](#border)
1718
1. [Sass](#sass)
1819
- [Syntax](#syntax)
1920
- [Ordering](#ordering-of-property-declarations)
@@ -169,6 +170,26 @@ We recommend creating JavaScript-specific classes to bind to, prefixed with `.js
169170
<button class="btn btn-primary js-request-to-book">Request to Book</button>
170171
```
171172

173+
### Border
174+
175+
Use `0` instead of `none` to specify that a style has no border.
176+
177+
**Bad**
178+
179+
```css
180+
.foo {
181+
border: none;
182+
}
183+
```
184+
185+
**Good**
186+
187+
```css
188+
.foo {
189+
border: 0;
190+
}
191+
```
192+
172193
## Sass
173194

174195
### Syntax

0 commit comments

Comments
 (0)