From 031de90ca6a151469b6831ef54a65cc56876baf1 Mon Sep 17 00:00:00 2001 From: BoRyan Eberhard Date: Sun, 6 Dec 2015 12:20:57 -0800 Subject: [PATCH] Correctly test for whitespace-only nodeValues As written, a nodeValue of "test test" will return True which appears to be the incorrect behavior. I believe only empty nodeValues and nodes that only have whitespace characters should return True. This fix looks for any non-whitespace characters in nodeValue and only returns True if none are found. --- src/jquery.columnizer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/jquery.columnizer.js b/src/jquery.columnizer.js index b63a410..2a9d515 100644 --- a/src/jquery.columnizer.js +++ b/src/jquery.columnizer.js @@ -348,9 +348,9 @@ var onlyNode = $clone.get(0).childNodes[0]; if(onlyNode.nodeType == 3){ // text node - var whitespace = /\s/; + var nonwhitespace = /\S/; var str = onlyNode.nodeValue; - if(whitespace.test(str)){ + if(!nonwhitespace.test(str)){ // yep, only a whitespace textnode $clone.remove(); $cloneMe.removeClass(prefixTheClassName("split"));