Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/jquery-ujs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: akzhan/jquery-ujs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: asynchronous-call-to-confirm
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 4 files changed
  • 3 contributors

Commits on Sep 2, 2011

  1. Use Deferred object as result of $.rails.confirm. It allows to overri… 

    …de confirm in an asynchronic fashion.
    @akzhan
    akzhan committed Sep 2, 2011
    Configuration menu
    Copy the full SHA
    fba4ee3 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2011

  1. Reformatted some stuff and moved preventDefault events to be less obt… 

    …rusive
    @JangoSteve
    JangoSteve committed Sep 4, 2011
    Configuration menu
    Copy the full SHA
    e090f2b View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2011

  1. Rewrote portion of rails.confirm deferred calls to eliminate double-t… 

    …riggering

of directly bound handlers outside of jquery-ujs. See #196.
    @JangoSteve
    JangoSteve committed Oct 3, 2011
    Configuration menu
    Copy the full SHA
    bffb813 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2011

  1. Added data-ujs-generated attribute to handleRemote-generated forms. 

    Cleaned up stray forms causing issues in test suite.
    @JangoSteve
    JangoSteve committed Oct 4, 2011
    Configuration menu
    Copy the full SHA
    e16a950 View commit details
    Browse the repository at this point in the history

  2. Added test to ensure direct click-bindings for data-confirm links only 

    trigger once. See #196
    @JangoSteve
    JangoSteve committed Oct 4, 2011
    Configuration menu
    Copy the full SHA
    03c9f0c View commit details
    Browse the repository at this point in the history

  3. Created test to ensure direct form submit binding triggers only once for 

    non-remote data-confirm forms. See #196
    @JangoSteve
    JangoSteve committed Oct 4, 2011
    Configuration menu
    Copy the full SHA
    78cc23f View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2011

  1. Fix e typo.

    @akzhan
    Nicholas Firth-McCoy authored and akzhan committed Nov 17, 2011
    Configuration menu
    Copy the full SHA
    a9b9222 View commit details
    Browse the repository at this point in the history
Loading