Remove dependency on Glide, Picasso, SVG, and multidex. (commons-app#1859)

* Eliminate the use of Picasso.

This gets rid of the single use of the Picasso library (which was causing
the whole library to be imported and shipped) and replaces it with Glide.
TODO: replace this and the other instance(s) of Glide usage with Fresco,
or vice versa.

* Remove dependency on Glide.

This removes the dependency on Glide, as well as the SVG rendering
library, whose only purpose was to display a single SVG image in the
Notification activity. Unfortunately Android doesn't support SVG natively,
but Echo notifications have icons that are SVG formatted. Rather than
import a bunch of heavy libraries to support this single case of SVG
rendering, we can simply create a few local drawables that correspond to
the different types of notifications, and use them instead.

* Remove multidex!

Multidex is a killer of performance and should be avoided at all costs.

* Remove further unused bits.

* Remove final vestige of multidex.

Author: dbrant

README.md

@@ -39,11 +39,9 @@ We try to have an extensive documentation at [our wiki here at Github][5]:
 * [Fresco][27]
 * [Stetho][28]
 * [Dagger][29]
-* [AndroidSVG][30]
-* [Java-HTTP-Fluent][31]
-* [CircleProgressBar][32]
-* [Glide][33]
-* [Leak Canary][34]
+* [Java-HTTP-Fluent][30]
+* [CircleProgressBar][31]
+* [Leak Canary][32]
 
 ## License ##
 
@@ -80,8 +78,6 @@ This software is open source, licensed under the [Apache License 2.0][4].
 [27]: https://github.com/facebook/fresco
 [28]: https://github.com/facebook/stetho
 [29]: https://github.com/google/dagger
-[30]: https://github.com/BigBadaboom/androidsvg
-[31]: https://github.com/yuvipanda/java-http-fluent/blob/master/src/main/java/in/yuvi/http/fluent/Http.java
-[32]: https://github.com/dinuscxj/CircleProgressBar
-[33]: https://github.com/bumptech/glide
-[34]: https://github.com/square/leakcanary
+[30]: https://github.com/yuvipanda/java-http-fluent/blob/master/src/main/java/in/yuvi/http/fluent/Http.java
+[31]: https://github.com/dinuscxj/CircleProgressBar
+[32]: https://github.com/square/leakcanary

app/build.gradle

@@ -7,7 +7,6 @@ apply from: 'quality.gradle'
 apply plugin: 'com.getkeepsafe.dexcount'
 
 dependencies {
-    implementation 'com.squareup.picasso:picasso:2.71828'
     implementation 'com.prof.rssparser:rssparser:1.1'
     implementation 'com.github.nicolas-raoul:Quadtree:ac16ea8035bf07'
     implementation 'fr.avianey.com.viewpagerindicator:library:2.4.1.1@aar'
@@ -40,7 +39,6 @@ dependencies {
     implementation 'io.reactivex.rxjava2:rxandroid:2.0.1'
     // Because RxAndroid releases are few and far between, it is recommended you also
     // explicitly depend on RxJava's latest version for bug fixes and new features.
-    implementation 'com.android.support:multidex:1.0.3'
     implementation 'io.reactivex.rxjava2:rxjava:2.1.2'
     implementation 'com.jakewharton.rxbinding2:rxbinding:2.0.0'
     implementation 'com.jakewharton.rxbinding2:rxbinding-support-v4:2.0.0'
@@ -53,7 +51,6 @@ dependencies {
     implementation "com.google.dagger:dagger-android-support:$DAGGER_VERSION"
     kapt "com.google.dagger:dagger-android-processor:$DAGGER_VERSION"
     kapt "com.google.dagger:dagger-compiler:$DAGGER_VERSION"
-    testImplementation 'org.robolectric:multidex:3.4.2'
     testImplementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
     testImplementation "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
     testImplementation 'junit:junit:4.12'
@@ -62,10 +59,6 @@ dependencies {
     testImplementation 'com.squareup.okhttp3:mockwebserver:3.8.1'
     implementation 'com.dinuscxj:circleprogressbar:1.1.1'
 
-    implementation 'com.caverock:androidsvg:1.2.1'
-    implementation 'com.github.bumptech.glide:glide:4.7.1'
-    kapt 'com.github.bumptech.glide:compiler:4.7.1'
-
     androidTestImplementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
     androidTestImplementation 'com.squareup.okhttp3:mockwebserver:3.8.1'
     androidTestImplementation "com.android.support:support-annotations:$SUPPORT_LIB_VERSION"
@@ -95,8 +88,6 @@ android {
         targetSdkVersion project.targetSdkVersion
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true
-
-        multiDexEnabled true
     }
 
     testOptions {
@@ -117,7 +108,7 @@ android {
     buildTypes {
         release {
             minifyEnabled false // See https://stackoverflow.com/questions/40232404/google-play-apk-and-android-studio-apk-usb-debug-behaving-differently - proguard.cfg modification alone insufficient.
-            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt', 'proguard-glide.txt'
+            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
         }
         debug {
             testCoverageEnabled true

app/proguard-glide.txt

@@ -1,13 +1,13 @@
 package fr.free.nrw.commons;
 
+import android.app.Application;
 import android.app.NotificationChannel;
 import android.app.NotificationManager;
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.database.sqlite.SQLiteDatabase;
 import android.os.Build;
 import android.support.annotation.RequiresApi;
-import android.support.multidex.MultiDexApplication;
 
 import com.facebook.drawee.backends.pipeline.Fresco;
 import com.facebook.imagepipeline.core.ImagePipelineConfig;
@@ -45,7 +45,7 @@
         resDialogCommentPrompt = R.string.crash_dialog_comment_prompt,
         resDialogOkToast = R.string.crash_dialog_ok_toast
 )
-public class CommonsApplication extends MultiDexApplication {
+public class CommonsApplication extends Application {
 
     @Inject SessionManager sessionManager;
     @Inject DBOpenHelper dbOpenHelper;

app/src/main/java/fr/free/nrw/commons/CommonsApplication.java

@@ -1,6 +1,5 @@
 package fr.free.nrw.commons.notification;
 
-import android.graphics.drawable.PictureDrawable;
 import android.text.Html;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -9,23 +8,17 @@
 import android.widget.TextView;
 
 import com.borjabravo.readmoretextview.ReadMoreTextView;
-import com.bumptech.glide.RequestBuilder;
 import com.pedrogomez.renderers.Renderer;
 
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import fr.free.nrw.commons.R;
-import fr.free.nrw.commons.glide.SvgSoftwareLayerSetter;
-
-import static com.bumptech.glide.load.resource.drawable.DrawableTransitionOptions.withCrossFade;
 
 /**
  * Created by root on 19.12.2017.
  */
 
 public class NotificationRenderer extends Renderer<Notification> {
-    private RequestBuilder<PictureDrawable> requestBuilder;
-
     @BindView(R.id.title) ReadMoreTextView title;
     @BindView(R.id.time) TextView time;
     @BindView(R.id.icon) ImageView icon;
@@ -48,11 +41,6 @@ protected void hookListeners(View rootView) {
     protected View inflate(LayoutInflater layoutInflater, ViewGroup viewGroup) {
         View inflatedView = layoutInflater.inflate(R.layout.item_notification, viewGroup, false);
         ButterKnife.bind(this, inflatedView);
-        requestBuilder = GlideApp.with(inflatedView.getContext())
-                .as(PictureDrawable.class)
-                .error(R.drawable.round_icon_unknown)
-                .transition(withCrossFade())
-                .listener(new SvgSoftwareLayerSetter());
         return inflatedView;
     }
 
@@ -61,7 +49,6 @@ public void render() {
         Notification notification = getContent();
         setTitle(notification.notificationText);
         time.setText(notification.date);
-        requestBuilder.load(notification.iconUrl).into(icon);
     }
 
     /**