Add bookmark from list fragment

Author: neslihanturan

app/src/main/java/fr/free/nrw/commons/nearby/PlaceRenderer.java

@@ -33,9 +33,11 @@
 import fr.free.nrw.commons.contributions.ContributionController;
 import fr.free.nrw.commons.di.ApplicationlessInjection;
 import fr.free.nrw.commons.kvstore.JsonKvStore;
+import fr.free.nrw.commons.nearby.mvp.fragments.NearbyMapFragment;
 import fr.free.nrw.commons.nearby.mvp.fragments.NearbyParentFragment;
 import timber.log.Timber;
 
+import static fr.free.nrw.commons.nearby.mvp.fragments.NearbyParentFragment.TAG_RETAINED_MAP_FRAGMENT;
 import static fr.free.nrw.commons.theme.NavigationBaseActivity.startActivityWithFlags;
 import static fr.free.nrw.commons.wikidata.WikidataConstants.PLACE_OBJECT;
 
@@ -191,8 +193,9 @@ protected void hookListeners(View view) {
                     onBookmarkClick.onClick();
                 }
                 else {
-                    // TODO nesli
-                    //((NearbyMapFragment)((NearbyFragment)((NearbyListFragment)fragment).getParentFragment()).getChildFragmentManager().findFragmentByTag(NearbyMapFragment.class.getSimpleName())).updateMarker(isBookmarked, place);
+                    ((NearbyMapFragment)(fragment.getParentFragment()).getChildFragmentManager().
+                            findFragmentByTag(TAG_RETAINED_MAP_FRAGMENT)).
+                            updateMarker(isBookmarked, place, null);
                 }
             }
         });

app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyMapFragment.java

@@ -405,7 +405,7 @@ void setMapMarkerActions(Marker selected, NearbyParentFragmentPresenter nearbyPa
         });
     }
 
-    public void updateMarker(boolean isBookmarked, Place place, LatLng curLatLng) {
+    public void updateMarker(boolean isBookmarked, Place place, @Nullable LatLng curLatLng) {
 
         VectorDrawableCompat vectorDrawable;
         if (isBookmarked) {
@@ -421,8 +421,10 @@ public void updateMarker(boolean isBookmarked, Place place, LatLng curLatLng) {
             if (marker.getTitle() != null && marker.getTitle().equals(place.getName())) {
 
                 Bitmap icon = UiUtils.getBitmap(vectorDrawable);
-                String distance = formatDistanceBetween(curLatLng, place.location);
-                place.setDistance(distance);
+                if (curLatLng != null) {
+                    String distance = formatDistanceBetween(curLatLng, place.location);
+                    place.setDistance(distance);
+                }
 
                 NearbyBaseMarker nearbyBaseMarker = new NearbyBaseMarker();
                 nearbyBaseMarker.title(place.name);

app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyParentFragment.java

@@ -206,8 +206,8 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment
     NearbyMapFragment nearbyMapFragment;
 
     private fr.free.nrw.commons.nearby.NearbyListFragment nearbyListFragment;
-    private static final String TAG_RETAINED_MAP_FRAGMENT = com.mapbox.mapboxsdk.maps.SupportMapFragment.class.getSimpleName();
-    private static final String TAG_RETAINED_LIST_FRAGMENT = NearbyListFragment.class.getSimpleName();
+    public static final String TAG_RETAINED_MAP_FRAGMENT = NearbyMapFragment.class.getSimpleName();
+    public static final String TAG_RETAINED_LIST_FRAGMENT = NearbyListFragment.class.getSimpleName();
 
     @Override
     public View onCreateView(LayoutInflater inflater, ViewGroup container,