Skip to content

Commit f3d7465

Browse files
committed
that fields doesnt popup because they was shown only after onAuthCookieAcquired fired
1 parent 31b12ba commit f3d7465

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

app/src/main/java/fr/free/nrw/commons/auth/AuthenticatedActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
import fr.free.nrw.commons.CommonsApplication;
1414
import fr.free.nrw.commons.theme.NavigationBaseActivity;
15+
import timber.log.Timber;
1516

1617
public abstract class AuthenticatedActivity extends NavigationBaseActivity {
1718

app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -209,16 +209,6 @@ public void onBackPressed() {
209209
protected void onAuthCookieAcquired(String authCookie) {
210210
app.getMWApi().setAuthCookie(authCookie);
211211

212-
SingleUploadFragment shareView = (SingleUploadFragment) getSupportFragmentManager().findFragmentByTag("shareView");
213-
categorizationFragment = (CategorizationFragment) getSupportFragmentManager().findFragmentByTag("categorization");
214-
if(shareView == null && categorizationFragment == null) {
215-
shareView = new SingleUploadFragment();
216-
getSupportFragmentManager()
217-
.beginTransaction()
218-
.add(R.id.single_upload_fragment_container, shareView, "shareView")
219-
.commitAllowingStateLoss();
220-
}
221-
uploadController.prepareService();
222212
}
223213

224214
@Override
@@ -311,6 +301,18 @@ R.drawable.ic_error_outline_black_24dp, getTheme()))
311301
}
312302
}
313303
performPreuploadProcessingOfFile();
304+
305+
306+
SingleUploadFragment shareView = (SingleUploadFragment) getSupportFragmentManager().findFragmentByTag("shareView");
307+
categorizationFragment = (CategorizationFragment) getSupportFragmentManager().findFragmentByTag("categorization");
308+
if(shareView == null && categorizationFragment == null) {
309+
shareView = new SingleUploadFragment();
310+
getSupportFragmentManager()
311+
.beginTransaction()
312+
.add(R.id.single_upload_fragment_container, shareView, "shareView")
313+
.commitAllowingStateLoss();
314+
}
315+
uploadController.prepareService();
314316
}
315317

316318
@Override

0 commit comments

Comments
 (0)