Shifted strings to String.xml

Author: tanvidadu

app/src/main/java/fr/free/nrw/commons/delete/ReasonBuilder.java

@@ -71,8 +71,10 @@ private void fetchArticleNumber() {
     }
 
     private void appendArticlesUsed(FeedbackResponse object){
-        reason += ". Uploaded by myself on" + prettyUploadedDate(media);
-        reason += ",used in " + object.getArticlesUsingImages() + " articles";
+        reason += context.getString(R.string.uploaded_by_myself).toString() + prettyUploadedDate(media);
+        reason += context.getString(R.string.used_by).toString()
+                + object.getArticlesUsingImages()
+                + context.getString(R.string.articles).toString();
         Log.i("New Reason", reason);
     }
 

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -171,11 +171,11 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
         }
 
         reasonList = new ArrayList<>();
-        reasonList.add(getString(R.string.deletion_reason_1));
-        reasonList.add(getString(R.string.deletion_reason_2));
-        reasonList.add(getString(R.string.deletion_reason_3));
-        reasonList.add(getString(R.string.deletion_reason_4));
-        reasonList.add(getString(R.string.deletion_reason_5));
+        reasonList.add(getString(R.string.deletion_reason_uploaded_by_mistake));
+        reasonList.add(getString(R.string.deletion_reason_publicly_visible));
+        reasonList.add(getString(R.string.deletion_reason_not_interesting));
+        reasonList.add(getString(R.string.deletion_reason_no_longer_want_public));
+        reasonList.add(getString(R.string.deletion_reason_bad_for_my_privacy));
 
         categoryNames = new ArrayList<>();
         categoryNames.add(getString(R.string.detail_panel_cats_loading));

app/src/main/res/values/strings.xml

@@ -368,10 +368,13 @@
   <string name="log_collection_started">Log collection started. Please RESTART the app, perform action that you wish to log, and then tap \'Send log file\' again</string>
   <string name="no_uploads">Welcome to Commons!\n Upload your first media by touching the camera or gallery icon above.</string>
 
-  <string name="deletion_reason_1">I uploaded it by mistake</string>
-  <string name="deletion_reason_2">I did not know it would be publicly visible</string>
-  <string name="deletion_reason_3">I realized it is bad for my privacy</string>
-  <string name="deletion_reason_4">I changed my mind, I don\'t want it to be publicly visible anymore</string>
-  <string name="deletion_reason_5">Sorry this picture is not interesting for an encyclopedia</string>
+  <string name="deletion_reason_uploaded_by_mistake">I uploaded it by mistake</string>
+  <string name="deletion_reason_publicly_visible">I did not know it would be publicly visible</string>
+  <string name="deletion_reason_bad_for_my_privacy">I realized it is bad for my privacy</string>
+  <string name="deletion_reason_no_longer_want_public">I changed my mind, I don\'t want it to be publicly visible anymore</string>
+  <string name="deletion_reason_not_interesting">Sorry this picture is not interesting for an encyclopedia</string>
+  <string name="uploaded_by_myself">Uploaded by myself on</string>
+  <string name="used_by">,used in</string>
+  <string name="articles">articles</string>
 
 </resources>