Skip to content

Commit 01866fc

Browse files
committed
sidebar - fixed colapsable without href causing error
1 parent f84b52a commit 01866fc

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/js/bundle.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1680,7 +1680,8 @@ class KromaSidebar {
16801680
for(var i = 0; i < this.pages.length; i++){
16811681

16821682
var li = document.createElement('li');
1683-
li.querySelector('a').removeAttribute('href'); //remove href from collapsable parent
1683+
//remove href from collapsable parent
1684+
if (li.querySelector('a') && element.hasAttribute('href')) {li.querySelector('a').removeAttribute('href');}
16841685
li.classList.add('no-selection');
16851686

16861687
//parent page

src/js/components/sidebar.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ class KromaSidebar {
138138
for(var i = 0; i < this.pages.length; i++){
139139

140140
var li = document.createElement('li');
141-
li.querySelector('a').removeAttribute('href'); //remove href from collapsable parent
141+
//remove href from collapsable parent
142+
if (li.querySelector('a') && element.hasAttribute('href')) {li.querySelector('a').removeAttribute('href');}
142143
li.classList.add('no-selection');
143144

144145
//parent page

0 commit comments

Comments
 (0)