enforce double quotes via JSHint. Closes jquerygh-975

Author: mikesherov

.jshintrc

@@ -5,6 +5,7 @@
   "expr": true,
   "latedef": true,
   "noarg": true,
+  "quotmark": "double",
   "smarttabs": true,
   "trailing": true,
   "undef": true

grunt.js

@@ -153,7 +153,7 @@ module.exports = function( grunt ) {
 		}, {
 			authUsername: config.authUsername,
 			authToken: config.authToken,
-			jobName: 'jQuery commit #<a href="https://github.com/jquery/jquery/commit/' + commit + '">' + commit.substr( 0, 10 ) + '</a>',
+			jobName: "jQuery commit #<a href='https://github.com/jquery/jquery/commit/" + commit + "'>" + commit.substr( 0, 10 ) + "</a>",
 			runMax: config.runMax,
 			"runNames[]": tests,
 			"runUrls[]": testUrls,

package.json

@@ -26,7 +26,7 @@
 		"grunt-compare-size": ">=0.1.0",
 		"grunt-git-authors": ">=1.0.0",
 		"grunt-update-submodules": ">=0.1.0",
-		"grunt": "~0.3.9",
+		"grunt": "~0.3.17",
 		"testswarm": "0.2.2"
 	},
 	"keywords": []

src/.jshintrc

@@ -10,7 +10,8 @@
     "undef": true,
     "smarttabs": true,
     "sub": true,
-    "maxerr": 100
+    "maxerr": 100,
+    "quotmark": "double"
   },
   "globals": {
     "define": true,

test/.jshintrc

@@ -10,7 +10,8 @@
     "undef": true,
     "smarttabs": true,
     "maxerr": 100,
-    "sub": true
+    "sub": true,
+    "quotmark": "double"
   },
   "globals": {
     "define": true,

test/unit/ajax.js

@@ -2674,7 +2674,7 @@ if ( jQuery.ajax && ( !isLocal || hasPHP ) ) {
 				ok( false, "error callback called" );
 			}
 		}).fail(function( _, reason ) {
-			strictEqual( reason, 'canceled', "Request aborted by the prefilter must fail with 'canceled' status text" );
+			strictEqual( reason, "canceled", "Request aborted by the prefilter must fail with 'canceled' status text" );
 		});
 
 	});

test/unit/attributes.js

@@ -516,11 +516,11 @@ test("removeAttr(String)", function() {
 
 	try {
 		$first = jQuery("#first").attr("contenteditable", "true").removeAttr("contenteditable");
-		equal( $first.attr('contenteditable'), undefined, "Remove the contenteditable attribute" );
+		equal( $first.attr("contenteditable"), undefined, "Remove the contenteditable attribute" );
 	} catch(e) {
 		ok( false, "Removing contenteditable threw an error (#10429)" );
 	}
-	
+
 	$first = jQuery("<div Case='mixed'></div>");
 	equal( $first.attr("Case"), "mixed", "case of attribute doesn't matter" );
 	$first.removeAttr("Case");

test/unit/callbacks.js

@@ -32,14 +32,14 @@ var output,
 			};
 		}
 	};
-	
+
 	function showFlags( flags ) {
 		if ( typeof flags === "string" ) {
-			return '"' + flags + '"';
+			return "'" + flags + "'";
 		}
 		var output = [], key;
 		for ( key in flags ) {
-			output.push( '"' + key + '": ' + flags[ key ] );
+			output.push( "'" + key + "': " + flags[ key ] );
 		}
 		return "{ " + output.join( ", " ) + " }";
 	}

test/unit/core.js

@@ -567,7 +567,7 @@ test("XSS via location.hash", function() {
 	};
 	try {
 		// This throws an error because it's processed like an id
-		jQuery( '#<img id="check9521" src="no-such-.gif" onerror="jQuery._check9521(false)">' ).appendTo("#qunit-fixture");
+		jQuery( "#<img id='check9521' src='no-such-.gif' onerror='jQuery._check9521(false)'>" ).appendTo("#qunit-fixture");
 	} catch (err) {
 		jQuery["_check9521"](true);
 	}

test/unit/data.js

@@ -570,7 +570,10 @@ test("jQuery.data supports interoperable hyphenated/camelCase get/set of propert
 			"an-object": {},
 			"bool-true": true,
 			"bool-false": false,
-			"some-json": '{ "foo": "bar" }',
+			// JSHint enforces double quotes,
+			// but JSON strings need double quotes to parse
+			// so we need escaped double quotes here
+			"some-json": "{ \"foo\": \"bar\" }",
 			"num-1-middle": true,
 			"num-end-2": true,
 			"2-num-start": true
@@ -597,7 +600,10 @@ test("jQuery.data supports interoperable removal of hyphenated/camelCase propert
 			"an-object": {},
 			"bool-true": true,
 			"bool-false": false,
-			"some-json": '{ "foo": "bar" }'
+			// JSHint enforces double quotes,
+			// but JSON strings need double quotes to parse
+			// so we need escaped double quotes here
+			"some-json": "{ \"foo\": \"bar\" }"
 		};
 
 	expect( 27 );
@@ -650,7 +656,7 @@ test( "Only check element attributes once when calling .data() - #8909", functio
 
 test( "JSON data- attributes can have newlines", function() {
 	expect(1);
-	
+
 	var x = jQuery("<div data-some='{\n\"foo\":\n\t\"bar\"\n}'></div>");
 	equal( x.data("some").foo, "bar", "got a JSON data- attribute with spaces" );
 	x.remove();