CSV-124 replace string concatenation with StringBuilder

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1624061 13f79535-47bb-0310-9956-ffa450edef68

Author: Brent Worden

src/main/java/org/apache/commons/csv/CSVRecord.java

@@ -48,8 +48,7 @@ public final class CSVRecord implements Serializable, Iterable<String> {
     /** The values of the record */
     private final String[] values;
 
-    CSVRecord(final String[] values, final Map<String, Integer> mapping,
-            final String comment, final long recordNumber) {
+    CSVRecord(final String[] values, final Map<String, Integer> mapping, final String comment, final long recordNumber) {
         this.recordNumber = recordNumber;
         this.values = values != null ? values : EMPTY_STRING_ARRAY;
         this.mapping = mapping;
@@ -94,27 +93,26 @@ public String get(final int i) {
     public String get(final String name) {
         if (mapping == null) {
             throw new IllegalStateException(
-                    "No header mapping was specified, the record values can't be accessed by name");
+                "No header mapping was specified, the record values can't be accessed by name");
         }
         final Integer index = mapping.get(name);
         if (index == null) {
             throw new IllegalArgumentException(String.format("Mapping for %s not found, expected one of %s", name,
-                    mapping.keySet()));
+                mapping.keySet()));
         }
         try {
             return values[index.intValue()];
         } catch (final ArrayIndexOutOfBoundsException e) {
             throw new IllegalArgumentException(String.format(
-                    "Index for header '%s' is %d but CSVRecord only has %d values!", name, index,
-                    Integer.valueOf(values.length)));
+                "Index for header '%s' is %d but CSVRecord only has %d values!", name, index,
+                Integer.valueOf(values.length)));
         }
     }
 
     /**
      * Returns the comment for this record, if any.
      *
-     * @return the comment for this record, or null if no comment for this
-     *         record is available.
+     * @return the comment for this record, or null if no comment for this record is available.
      */
     public String getComment() {
         return comment;
@@ -176,14 +174,16 @@ public boolean isSet(final String name) {
      *
      * @return an iterator over the values of this record.
      */
+    @Override
     public Iterator<String> iterator() {
         return toList().iterator();
     }
 
     /**
      * Puts all values of this record into the given Map.
      *
-     * @param map The Map to populate.
+     * @param map
+     *            The Map to populate.
      * @return the given map.
      */
     <M extends Map<String, String>> M putIn(final M map) {
@@ -212,6 +212,7 @@ public int size() {
      * Converts the values to a List.
      *
      * TODO: Maybe make this public?
+     * 
      * @return a new List
      */
     private List<String> toList() {
@@ -227,7 +228,6 @@ public Map<String, String> toMap() {
         return putIn(new HashMap<String, String>(values.length));
     }
 
-
     /**
      * Returns a string representation of the contents of this record. The result is constructed by comment, mapping,
      * recordNumber and by passing the internal values array to {@link Arrays#toString(Object[])}.
@@ -236,14 +236,16 @@ public Map<String, String> toMap() {
      */
     @Override
     public String toString() {
-        return "CSVRecord [comment=" + comment + ", mapping=" + mapping +
-                ", recordNumber=" + recordNumber + ", values=" +
-                Arrays.toString(values) + "]";
+        StringBuilder sb = new StringBuilder();
+        sb.append("CSVRecord [comment=").append(comment);
+        sb.append(", mapping=").append(mapping);
+        sb.append(", recordNumber=").append(recordNumber);
+        sb.append(", values=").append(Arrays.toString(values)).append(']');
+        return sb.toString();
     }
 
     String[] values() {
         return values;
     }
 
-
 }