Handle empty String argument in CharsetDetector.trimAttrValue

gerhardgossen · gerhardgossen · commit c44e320ae6df · 2015-06-15T13:29:08.000+02:00
diff --git a/src/main/java/org/archive/format/text/charset/CharsetDetector.java b/src/main/java/org/archive/format/text/charset/CharsetDetector.java
@@ -178,6 +178,9 @@ protected String getCharsetFromMeta(byte buffer[],int len) throws IOException {
 	}
 
 	private static String trimAttrValue(String value) {
+		if (value.isEmpty()) {
+			return value;
+		}
 		String result = value;
 		if (result.charAt(0) == '"') {
 			result = result.substring(1, result.length() - 1);

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,9 @@ protected String getCharsetFromMeta(byte buffer[],int len) throws IOException {`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`private static String trimAttrValue(String value) {`
	`181`	`+ if (value.isEmpty()) {`
	`182`	`+ return value;`
	`183`	`+ }`
`181`	`184`	`String result = value;`
`182`	`185`	`if (result.charAt(0) == '"') {`
`183`	`186`	`result = result.substring(1, result.length() - 1);`