Skip to content

Commit f7cd67d

Browse files
committed
- Replaced direct references to "/tmp" with generic temporary directory reference using File.createTempFile().
Fixes bug reported in iipc/webarchive-commons Issue iipc#2.
1 parent 2491311 commit f7cd67d

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

src/test/java/org/archive/format/gzip/GZIPMemberWriterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
public class GZIPMemberWriterTest extends TestCase {
1313

1414
public void testWrite() throws IOException {
15-
String outPath = "/tmp/tmp.gz";
16-
GZIPMemberWriter gzw = new GZIPMemberWriter(new FileOutputStream(new File(outPath)));
15+
File outFile = File.createTempFile("tmp", ".gz");
16+
GZIPMemberWriter gzw = new GZIPMemberWriter(new FileOutputStream(outFile));
1717
gzw.write(new ByteArrayInputStream("Here is record 1".getBytes(IAUtils.UTF8)));
1818
gzw.write(new ByteArrayInputStream("Here is record 2".getBytes(IAUtils.UTF8)));
1919
}

src/test/java/org/archive/util/binsearch/SortedTextFileTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ private void createFile(File target, int max) throws FileNotFoundException {
2525

2626

2727
public void testGetRecordIteratorStringBoolean() throws IOException {
28-
File test = new File("/tmp/test.tmp");
28+
File test = File.createTempFile("test", null);
2929
int max = 1000000;
3030
createFile(test,max);
3131
RandomAccessFileSeekableLineReaderFactory factory =

src/test/java/org/archive/util/iterator/SortedCompositeIteratorTest.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,28 +4,24 @@
44
import java.io.File;
55
import java.io.FileNotFoundException;
66
import java.io.FileReader;
7+
import java.io.IOException;
78
import java.io.PrintWriter;
89
import java.util.Comparator;
910

1011
import junit.framework.TestCase;
1112

1213
public class SortedCompositeIteratorTest extends TestCase {
1314

14-
public void testHasNext() throws FileNotFoundException {
15+
public void testHasNext() throws FileNotFoundException, IOException {
1516

1617
long t = 210000;
1718
long c = 134;
1819
float f = (float)c / (float)t;
1920
System.err.format("F(%f)\n",f);
2021

21-
File a = new File("/tmp/a");
22-
File b = new File("/tmp/b");
23-
if(a.isFile()) {
24-
a.delete();
25-
}
26-
if(b.isFile()) {
27-
b.delete();
28-
}
22+
File a = File.createTempFile("filea", null);
23+
File b = File.createTempFile("fileb", null);
24+
2925
PrintWriter apw = new PrintWriter(a);
3026
PrintWriter bpw = new PrintWriter(b);
3127
apw.println("1");
@@ -38,6 +34,7 @@ public void testHasNext() throws FileNotFoundException {
3834
BufferedReader bbr = new BufferedReader(new FileReader(b));
3935
SortedCompositeIterator<String> sci = new SortedCompositeIterator<String>(new Comparator<String>() {
4036

37+
@Override
4138
public int compare(String o1, String o2) {
4239
return o1.compareTo(o2);
4340
}

0 commit comments

Comments
 (0)