buffer alloc. closes archiverjs#35

Author: ctalkington

lib/archivers/zip/constants.js

@@ -8,14 +8,14 @@
 module.exports = {
   WORD: 4,
   DWORD: 8,
-  EMPTY: new Buffer(0),
+  EMPTY: Buffer.alloc(0),
 
   SHORT: 2,
   SHORT_MASK: 0xffff,
   SHORT_SHIFT: 16,
-  SHORT_ZERO: new Buffer(Array(2)),
+  SHORT_ZERO: Buffer.alloc(Array(2)),
   LONG: 4,
-  LONG_ZERO: new Buffer(Array(4)),
+  LONG_ZERO: Buffer.alloc(Array(4)),
 
   MIN_VERSION_INITIAL: 10,
   MIN_VERSION_DATA_DESCRIPTOR: 20,

lib/archivers/zip/util.js

@@ -40,15 +40,15 @@ util.fromDosTime = function(buf) {
 };
 
 util.getEightBytes = function(v) {
-  var buf = new Buffer(8);
+  var buf = Buffer.alloc(8);
   buf.writeUInt32LE(v % 0x0100000000, 0);
   buf.writeUInt32LE((v / 0x0100000000) | 0, 4);
 
   return buf;
 };
 
 util.getShortBytes = function(v) {
-  var buf = new Buffer(2);
+  var buf = Buffer.alloc(2);
   buf.writeUInt16LE((v & 0xFFFF) >>> 0, 0);
 
   return buf;
@@ -59,7 +59,7 @@ util.getShortBytesValue = function(buf, offset) {
 };
 
 util.getLongBytes = function(v) {
-  var buf = new Buffer(4);
+  var buf = Buffer.alloc(4);
   buf.writeUInt32LE((v & 0xFFFFFFFF) >>> 0, 0);
 
   return buf;

lib/archivers/zip/zip-archive-output-stream.js

@@ -313,8 +313,8 @@ ZipArchiveOutputStream.prototype._writeCentralFileHeader = function(ae) {
   var extra = ae.getCentralDirectoryExtra();
 
   if (gpb.usesUTF8ForNames()) {
-    name = new Buffer(name);
-    comment = new Buffer(comment);
+    name = Buffer.alloc(name);
+    comment = Buffer.alloc(comment);
   }
 
   // name length
@@ -381,7 +381,7 @@ ZipArchiveOutputStream.prototype._writeLocalFileHeader = function(ae) {
   }
 
   if (gpb.usesUTF8ForNames()) {
-    name = new Buffer(name);
+    name = Buffer.alloc(name);
   }
 
   ae._offsets.file = this.offset;

lib/util/index.js

@@ -16,9 +16,9 @@ util.isStream = function(source) {
 
 util.normalizeInputSource = function(source) {
   if (source === null) {
-    return new Buffer(0);
+    return Buffer.alloc(0);
   } else if (typeof source === 'string') {
-    return new Buffer(source);
+    return Buffer.alloc(source);
   } else if (util.isStream(source) && !source._readableState) {
     var normalized = new PassThrough();
     source.pipe(normalized);

test/helpers/index.js

@@ -7,7 +7,7 @@ var Readable = require('readable-stream').Readable;
 var Writable = require('readable-stream').Writable;
 
 function binaryBuffer(n) {
-  var buffer = new Buffer(n);
+  var buffer = Buffer.alloc(n);
 
   for (var i = 0; i < n; i++) {
     buffer.writeUInt8(i&255, i);
@@ -21,7 +21,7 @@ module.exports.binaryBuffer = binaryBuffer;
 function BinaryStream(size, options) {
   Readable.call(this, options);
 
-  var buf = new Buffer(size);
+  var buf = Buffer.alloc(size);
 
   for (var i = 0; i < size; i++) {
     buf.writeUInt8(i&255, i);