Fix SpotBugs 4.7.0 issues.

garydgregory · garydgregory · commit 1af9b95aa30c · 2022-05-06T07:28:20.000-04:00
[INFO] BugInstance size is 3 [INFO] Error size is 0 [INFO] Total bugs: 3 Error: Medium: Method intentionally throws RuntimeException. [org.apache.commons.cli.Option] At Option.java:[lines 417-423] THROWS_METHOD_THROWS_RUNTIMEEXCEPTION Error: Medium: Method intentionally throws RuntimeException. [org.apache.commons.cli.Option] At Option.java:[lines 446-450] THROWS_METHOD_THROWS_RUNTIMEEXCEPTION Error: Medium: Method intentionally throws RuntimeException. [org.apache.commons.cli.Option] At Option.java:[lines 474-478] THROWS_METHOD_THROWS_RUNTIMEEXCEPTION Bump spotbugs from 4.6.0 to 4.7.0 #107.
diff --git a/pom.xml b/pom.xml
@@ -218,7 +218,7 @@
     <commons.felix.version>5.1.2</commons.felix.version>
     <biz.aQute.bndlib.version>6.0.0</biz.aQute.bndlib.version>
     <spotbugs.plugin.version>4.6.0.0</spotbugs.plugin.version>
-    <spotbugs.impl.version>4.6.0</spotbugs.impl.version>
+    <spotbugs.impl.version>4.7.0</spotbugs.impl.version>
     <commons.animal-sniffer.version>1.20</commons.animal-sniffer.version>
     <commons.japicmp.version>0.15.3</commons.japicmp.version>
     <clirr.skip>true</clirr.skip>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -21,6 +21,16 @@
   </properties>
   <body>
     <release version="1.6" date="tbd" description="New features and bug fixes">
+      <!-- FIX -->
+      <action type="update" dev="ggregory" due-to="Gary Gregory">
+        Fix SpotBugs Error: Medium: Method intentionally throws RuntimeException. [org.apache.commons.cli.Option] At Option.java:[lines 417-423] THROWS_METHOD_THROWS_RUNTIMEEXCEPTION
+      </action>
+      <action type="update" dev="ggregory" due-to="Gary Gregory">
+        Fix SpotBugs Error: Medium: Method intentionally throws RuntimeException. [org.apache.commons.cli.Option] At Option.java:[lines 446-450] THROWS_METHOD_THROWS_RUNTIMEEXCEPTION
+      </action>
+      <action type="update" dev="ggregory" due-to="Gary Gregory">
+        Fix SpotBugs Error: Medium: Method intentionally throws RuntimeException. [org.apache.commons.cli.Option] At Option.java:[lines 474-478] THROWS_METHOD_THROWS_RUNTIMEEXCEPTION
+      </action>
       <!-- ADD -->
       <action type="update" dev="ggregory" due-to="Dependabot, Gary Gregory">
         Add github/codeql-action.
@@ -32,8 +42,8 @@
       <action type="update" dev="ggregory" due-to="Gary Gregory">
         Bump actions/setup-java from 2 to 3.
       </action>
-      <action type="update" dev="ggregory" due-to="Gary Gregory">
-        Bump spotbugs from 4.5.3 to 4.6.0 #96
+      <action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">
+        Bump spotbugs from 4.5.3 to 4.7.0 #96, #107.
       </action>
       <action type="update" dev="ggregory" due-to="Dependabot">
         Bump spotbugs-maven-plugin from 4.5.3.0 to 4.6.0.0 #98.
diff --git a/src/main/java/org/apache/commons/cli/Option.java b/src/main/java/org/apache/commons/cli/Option.java
@@ -415,7 +415,7 @@ boolean acceptsArg() {
      */
     private void add(final String value) {
         if (!acceptsArg()) {
-            throw new RuntimeException("Cannot add value, list full.");
+            throw new IllegalArgumentException("Cannot add value, list full.");
         }
 
         // store value
@@ -444,7 +444,7 @@ public boolean addValue(final String value) {
      */
     void addValueForProcessing(final String value) {
         if (argCount == UNINITIALIZED) {
-            throw new RuntimeException("NO_ARGS_ALLOWED");
+            throw new IllegalArgumentException("NO_ARGS_ALLOWED");
         }
         processValue(value);
     }
@@ -475,7 +475,7 @@ public Object clone() {
             option.values = new ArrayList<>(values);
             return option;
         } catch (final CloneNotSupportedException cnse) {
-            throw new RuntimeException("A CloneNotSupportedException was thrown: " + cnse.getMessage());
+            throw new IllegalStateException("A CloneNotSupportedException was thrown: " + cnse.getMessage());
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ boolean acceptsArg() {`
`415`	`415`	`*/`
`416`	`416`	`private void add(final String value) {`
`417`	`417`	`if (!acceptsArg()) {`
`418`		`- throw new RuntimeException("Cannot add value, list full.");`
	`418`	`+ throw new IllegalArgumentException("Cannot add value, list full.");`
`419`	`419`	`}`
`420`	`420`
`421`	`421`	`// store value`
`@@ -444,7 +444,7 @@ public boolean addValue(final String value) {`
`444`	`444`	`*/`
`445`	`445`	`void addValueForProcessing(final String value) {`
`446`	`446`	`if (argCount == UNINITIALIZED) {`
`447`		`- throw new RuntimeException("NO_ARGS_ALLOWED");`
	`447`	`+ throw new IllegalArgumentException("NO_ARGS_ALLOWED");`
`448`	`448`	`}`
`449`	`449`	`processValue(value);`
`450`	`450`	`}`
`@@ -475,7 +475,7 @@ public Object clone() {`
`475`	`475`	`option.values = new ArrayList<>(values);`
`476`	`476`	`return option;`
`477`	`477`	`} catch (final CloneNotSupportedException cnse) {`
`478`		`- throw new RuntimeException("A CloneNotSupportedException was thrown: " + cnse.getMessage());`
	`478`	`+ throw new IllegalStateException("A CloneNotSupportedException was thrown: " + cnse.getMessage());`
`479`	`479`	`}`
`480`	`480`	`}`
`481`	`481`