Skip to content

Commit 2ff9573

Browse files
committed
Applying test and fix patch from CLI-51. Thanks to Brian Egge.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/branches/cli-1.0.x@540661 13f79535-47bb-0310-9956-ffa450edef68
1 parent b0e1b80 commit 2ff9573

2 files changed

Lines changed: 54 additions & 2 deletions

File tree

src/java/org/apache/commons/cli/PosixParser.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ protected String[] flatten(Options options, String[] arguments,
9999

100100
// an iterator for the command line tokens
101101
Iterator iter = Arrays.asList(arguments).iterator();
102-
String token = null;
102+
String token;
103103

104104
// process each command line token
105105
while (iter.hasNext())
@@ -302,7 +302,8 @@ else if (stopAtNonOption)
302302
}
303303
else
304304
{
305-
tokens.add("-" + ch);
305+
tokens.add(token);
306+
break;
306307
}
307308
}
308309
}
Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
package org.apache.commons.cli.bug;
18+
19+
import junit.framework.TestCase;
20+
import org.apache.commons.cli.CommandLine;
21+
import org.apache.commons.cli.CommandLineParser;
22+
import org.apache.commons.cli.Options;
23+
import org.apache.commons.cli.ParseException;
24+
import org.apache.commons.cli.PosixParser;
25+
import org.apache.commons.cli.OptionBuilder;
26+
import org.apache.commons.cli.Option;
27+
28+
/**
29+
* @author brianegge
30+
*/
31+
public class BugCLI51Test
32+
extends TestCase
33+
{
34+
public void test() throws Exception
35+
{
36+
Options options = buildCommandLineOptions();
37+
CommandLineParser parser = new PosixParser();
38+
String[] args = new String[] {"-t", "-something" };
39+
CommandLine commandLine;
40+
commandLine = parser.parse( options, args );
41+
assertEquals("-something", commandLine.getOptionValue( 't'));
42+
}
43+
44+
private Options buildCommandLineOptions()
45+
{
46+
Option opt = OptionBuilder.withArgName( "t").hasArg().create('t');
47+
Options options = new Options();
48+
options.addOption( opt);
49+
return options;
50+
}
51+
}

0 commit comments

Comments
 (0)