Fix bug pointed out by FindBugs - it was removing the Boolean from the options, not the option

hen · hen · commit 56ba9c6b01b0 · 2008-03-22T02:48:04.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@639940 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/java/org/apache/commons/cli2/commandline/WriteableCommandLineImpl.java b/src/java/org/apache/commons/cli2/commandline/WriteableCommandLineImpl.java
@@ -214,7 +214,7 @@ public void setDefaultValues(final Option option,
     public void setDefaultSwitch(final Option option,
                                  final Boolean defaultSwitch) {
         if (defaultSwitch == null) {
-            defaultSwitches.remove(defaultSwitch);
+            defaultSwitches.remove(option);
         } else {
             defaultSwitches.put(option, defaultSwitch);
         }

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ public void setDefaultValues(final Option option,`
`214`	`214`	`public void setDefaultSwitch(final Option option,`
`215`	`215`	`final Boolean defaultSwitch) {`
`216`	`216`	`if (defaultSwitch == null) {`
`217`		`- defaultSwitches.remove(defaultSwitch);`
	`217`	`+ defaultSwitches.remove(option);`
`218`	`218`	`} else {`
`219`	`219`	`defaultSwitches.put(option, defaultSwitch);`
`220`	`220`	`}`