Prefer a checkstyle suppression over a private constructor for package private class, otherwise the code coverage drops without a clean way to test the ctor.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@1440316 13f79535-47bb-0310-9956-ffa450edef68

Author: netomi

src/conf/checkstyle-suppressions.xml

@@ -30,4 +30,9 @@
   <!-- Constant used in hashCode() method                                       -->
   <suppress checks="MagicNumber" files="Option.java" />
 
+  <!-- These are final package private classes, and we do not want to hide the
+       constructor as this will negatively affect the code coverage             -->
+  <suppress checks="HideUtilityClassConstructor" files="OptionValidator.java" />
+  <suppress checks="HideUtilityClassConstructor" files="Util.java" />
+
 </suppressions>

src/main/java/org/apache/commons/cli/OptionValidator.java

@@ -26,13 +26,6 @@
  */
 final class OptionValidator
 {
-    /**
-     * Hide constructor for a utility class.
-     */
-    private OptionValidator()
-    {
-    }
-
     /**
      * Validates whether <code>opt</code> is a permissible Option
      * shortOpt.  The rules that specify if the <code>opt</code>

src/main/java/org/apache/commons/cli/Util.java

@@ -25,13 +25,6 @@
  */
 final class Util
 {
-    /**
-     * Hide constructor for a utility class.
-     */
-    private Util()
-    {
-    }
-
     /**
      * Remove the hyphens from the beginning of <code>str</code> and
      * return the new String.