Statement unnecessarily nested within else clause.

garydgregory · garydgregory · commit 700f05292777 · 2015-05-03T17:09:29.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@1677451 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/cli/PosixParser.java b/src/main/java/org/apache/commons/cli/PosixParser.java
@@ -154,11 +154,8 @@ else if (!options.getMatchingOptions(token).isEmpty())
                     {
                         throw new AmbiguousOptionException(token, matchingOpts);
                     }
-                    else
-                    {
-                        Option opt = options.getOption(matchingOpts.get(0));
-                        processOptionToken("-" + opt.getLongOpt(), stopAtNonOption);
-                    }
+                    Option opt = options.getOption(matchingOpts.get(0));
+                    processOptionToken("-" + opt.getLongOpt(), stopAtNonOption);
                 }
                 // requires bursting
                 else

Original file line number	Diff line number	Diff line change
`@@ -154,11 +154,8 @@ else if (!options.getMatchingOptions(token).isEmpty())`
`154`	`154`	`{`
`155`	`155`	`throw new AmbiguousOptionException(token, matchingOpts);`
`156`	`156`	`}`
`157`		`- else`
`158`		`- {`
`159`		`- Option opt = options.getOption(matchingOpts.get(0));`
`160`		`- processOptionToken("-" + opt.getLongOpt(), stopAtNonOption);`
`161`		`- }`
	`157`	`+ Option opt = options.getOption(matchingOpts.get(0));`
	`158`	`+ processOptionToken("-" + opt.getLongOpt(), stopAtNonOption);`
`162`	`159`	`}`
`163`	`160`	`// requires bursting`
`164`	`161`	`else`