Applying my patch from CLI-170 - TypeHandler prints messages to stderr. It doesn't change the default behaviour, but it does provide a new method which maybe called to not get the stderr output and instead get a checked exception thrown.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/branches/cli-1.x@735247 13f79535-47bb-0310-9956-ffa450edef68

Author: hen

src/java/org/apache/commons/cli/CommandLine.java

@@ -85,8 +85,29 @@ public boolean hasOption(char opt)
      *
      * @param opt the name of the option
      * @return the type of this <code>Option</code>
+     * @deprecated due to System.err message. Instead use getParsedOptionValue(String)
      */
     public Object getOptionObject(String opt)
+    {
+        try {
+            return getParsedOptionValue(opt);
+        } catch(ParseException pe) {
+            System.err.println("Exception found converting " + opt + " to desired type: " + 
+                pe.getMessage() );
+            return null;
+        }
+    }
+
+    /**
+     * Return a version of this <code>Option</code> converted to a particular type. 
+     *
+     * @param opt the name of the option
+     * @return the value parsed into a particluar object
+     * @throws ParseException if there are problems turning the option value into the desired type
+     * @see PatternOptionBuilder
+     */
+    public Object getParsedOptionValue(String opt)
+    throws ParseException
     {
         String res = getOptionValue(opt);
 

src/java/org/apache/commons/cli/TypeHandler.java

@@ -44,6 +44,7 @@ public class TypeHandler
      * the value of <code>str</code>.
      */
     public static Object createValue(String str, Object obj)
+    throws ParseException
     {
         return createValue(str, (Class) obj);
     }
@@ -58,6 +59,7 @@ public static Object createValue(String str, Object obj)
      * the value of <code>str</code>.
      */
     public static Object createValue(String str, Class clazz)
+    throws ParseException
     {
         if (PatternOptionBuilder.STRING_VALUE == clazz)
         {
@@ -109,6 +111,7 @@ else if (PatternOptionBuilder.URL_VALUE == clazz)
       * the Object.
       */
     public static Object createObject(String classname)
+    throws ParseException
     {
         Class cl = null;
 
@@ -118,9 +121,7 @@ public static Object createObject(String classname)
         }
         catch (ClassNotFoundException cnfe)
         {
-            System.err.println("Unable to find the class: " + classname);
-
-            return null;
+            throw new ParseException("Unable to find the class: " + classname);
         }
 
         Object instance = null;
@@ -131,7 +132,7 @@ public static Object createObject(String classname)
         }
         catch (Exception e)
         {
-            System.err.println(e.getClass().getName() + "; Unable to create an instance of: " + classname);
+            throw new ParseException(e.getClass().getName() + "; Unable to create an instance of: " + classname);
         }
 
         return instance;
@@ -146,6 +147,7 @@ public static Object createObject(String classname)
      * is not a number, null is returned.
      */
     public static Number createNumber(String str)
+    throws ParseException
     {
         try
         {
@@ -160,10 +162,8 @@ public static Number createNumber(String str)
         }
         catch (NumberFormatException e)
         {
-            System.err.println(e.getMessage());
+            throw new ParseException(e.getMessage());
         }
-
-        return null;
     }
 
     /**
@@ -173,16 +173,15 @@ public static Number createNumber(String str)
      * @return The class if it is found, otherwise return null
      */
     public static Class createClass(String classname)
+    throws ParseException
     {
         try
         {
             return Class.forName(classname);
         }
         catch (ClassNotFoundException e)
         {
-            System.err.println("Unable to find the class: " + classname);
-
-            return null;
+            throw new ParseException("Unable to find the class: " + classname);
         }
     }
 
@@ -194,6 +193,7 @@ public static Class createClass(String classname)
      * otherwise return null.
      */
     public static Date createDate(String str)
+    throws ParseException
     {
         throw new UnsupportedOperationException("Not yet implemented");
     }
@@ -206,16 +206,15 @@ public static Date createDate(String str)
      * return null.
      */
     public static URL createURL(String str)
+    throws ParseException
     {
         try
         {
             return new URL(str);
         }
         catch (MalformedURLException e)
         {
-            System.err.println("Unable to parse the URL: " + str);
-
-            return null;
+            throw new ParseException("Unable to parse the URL: " + str);
         }
     }
 
@@ -226,6 +225,7 @@ public static URL createURL(String str)
      * @return The file represented by <code>str</code>.
      */
     public static File createFile(String str)
+    throws ParseException
     {
         return new File(str);
     }
@@ -237,6 +237,7 @@ public static File createFile(String str)
      * @return The File[] represented by <code>str</code>.
      */
     public static File[] createFiles(String str)
+    throws ParseException
     {
         // to implement/port:
         //        return FileW.findFiles(str);