Skip to content

Commit c6b932c

Browse files
committed
Replace internal StringBuffer with StringBuilder
1 parent cc36408 commit c6b932c

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/changes/changes.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
<action type="fix" issue="CLI-334" dev="ggregory" due-to="Eric Pugh">Fix Javadoc pathing #280.</action>
3232
<action type="fix" issue="CLI-335" dev="ggregory" due-to="Claude Warren">Updated properties documentation #285.</action>
3333
<action type="fix" issue="CLI-336" dev="ggregory" due-to="Claude Warren, Gary Gregory">Deprecation not always reported #284.</action>
34+
<action type="fix" dev="ggregory" due-to="Gary Gregory">Replace internal StringBuffer with StringBuilder.</action>
3435
<!-- UPDATE -->
3536
<action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump org.apache.commons:commons-parent from 70 to 72 #283.</action>
3637
</release>

src/main/java/org/apache/commons/cli/HelpFormatter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -801,13 +801,13 @@ protected StringBuffer renderOptions(final StringBuffer sb, final int width, fin
801801
// sort options ascending
802802
int max = 0;
803803
int maxSince = showSince ? determineMaxSinceLength(options) + leftPad : 0;
804-
final List<StringBuffer> prefixList = new ArrayList<>();
804+
final List<StringBuilder> prefixList = new ArrayList<>();
805805
final List<Option> optList = options.helpOptions();
806806
if (getOptionComparator() != null) {
807807
Collections.sort(optList, getOptionComparator());
808808
}
809809
for (final Option option : optList) {
810-
final StringBuffer optBuf = new StringBuffer();
810+
final StringBuilder optBuf = new StringBuilder();
811811
if (option.getOpt() == null) {
812812
optBuf.append(lpad).append(" ").append(getLongOptPrefix()).append(option.getLongOpt());
813813
} else {

0 commit comments

Comments
 (0)