- minor code tidy

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/trunk@279205 13f79535-47bb-0310-9956-ffa450edef68

Author: John Keyes

src/java/org/apache/commons/cli2/option/Command.java

@@ -86,12 +86,9 @@ public Command(
         this.preferredName = preferredName;
 
         // gracefully and defensively handle aliases
-        if (aliases == null) {
-            this.aliases = Collections.EMPTY_SET;
-        }
-        else {
-            this.aliases = Collections.unmodifiableSet(new HashSet(aliases));
-        }
+        this.aliases = (aliases == null) 
+            ? Collections.EMPTY_SET 
+            : Collections.unmodifiableSet(new HashSet(aliases));
 
         // populate the triggers Set
         final Set newTriggers = new HashSet();

src/java/org/apache/commons/cli2/option/DefaultOption.java

@@ -98,20 +98,13 @@ public DefaultOption(
         this.burstLength = shortPrefix.length() + 1;
 
         this.preferredName = preferredName;
-        if (aliases == null) {
-            this.aliases = Collections.EMPTY_SET;
-        }
-        else {
-            this.aliases = Collections.unmodifiableSet(new HashSet(aliases));
-        }
+        this.aliases = (aliases == null) 
+            ? Collections.EMPTY_SET
+            : Collections.unmodifiableSet(new HashSet(aliases));
 
-        if (burstAliases == null) {
-            this.burstAliases = Collections.EMPTY_SET;
-        }
-        else {
-            this.burstAliases =
-                Collections.unmodifiableSet(new HashSet(burstAliases));
-        }
+        this.burstAliases = (burstAliases == null)
+            ? Collections.EMPTY_SET
+            : Collections.unmodifiableSet(new HashSet(burstAliases));
 
         final Set newTriggers = new HashSet();
         newTriggers.add(preferredName);

src/java/org/apache/commons/cli2/option/ParentImpl.java

@@ -114,12 +114,9 @@ public boolean canProcess(final WriteableCommandLine commandLine, final String a
      * @see org.apache.commons.cli2.Option#prefixes()
      */
     public Set getPrefixes() {
-        if (children == null) {
-            return Collections.EMPTY_SET;
-        }
-        else {
-            return children.getPrefixes();
-        }
+        return (children == null)
+            ? Collections.EMPTY_SET
+            : children.getPrefixes();
     }
 
     /*