Option.Builder.option("") should throw IllegalArgumentException instead

garydgregory · garydgregory · commit de0e4186870f · 2024-04-09T11:02:43.000-04:00
of ArrayIndexOutOfBoundsException
diff --git a/src/test/java/org/apache/commons/cli/OptionTest.java b/src/test/java/org/apache/commons/cli/OptionTest.java
@@ -123,7 +123,7 @@ public void testBuilderInsufficientParams2() {
 
     @Test
     public void testBuilderInvalidOptionName0() {
-        assertNull(Option.builder().option(null));
+        assertThrows(IllegalArgumentException.class, () -> Option.builder().option(null).build());
         assertThrows(IllegalArgumentException.class, () -> Option.builder().option(""));
         assertThrows(IllegalArgumentException.class, () -> Option.builder().option(" "));
     }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public void testBuilderInsufficientParams2() {`
`123`	`123`
`124`	`124`	`@Test`
`125`	`125`	`public void testBuilderInvalidOptionName0() {`
`126`		`- assertNull(Option.builder().option(null));`
	`126`	`+ assertThrows(IllegalArgumentException.class, () -> Option.builder().option(null).build());`
`127`	`127`	`assertThrows(IllegalArgumentException.class, () -> Option.builder().option(""));`
`128`	`128`	`assertThrows(IllegalArgumentException.class, () -> Option.builder().option(" "));`
`129`	`129`	`}`