Skip to content

Commit e2e9472

Browse files
committed
As #38845 states, three tests in this class fail. This is because they make assumptions about the default datetime formatting instances. I've made them non-default, which should allow tests to pass. Two do pass for me, but the third oddly enough doesn't - somehow it turns 23-Dec-2003 into 2003-12-22. Very odd.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/trunk@384139 13f79535-47bb-0310-9956-ffa450edef68
1 parent 8576b53 commit e2e9472

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/test/org/apache/commons/cli2/validation/DateValidatorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public void testDefaultDateFormatValidate()
6060
throws InvalidArgumentException {
6161
final Object[] array = new Object[] { "23-Dec-2003" };
6262
final List list = Arrays.asList(array);
63-
final Validator validator = DateValidator.getDateInstance();
63+
final Validator validator = new DateValidator( new SimpleDateFormat("dd-MMM-yyyy") );
6464

6565
validator.validate(list);
6666

@@ -73,7 +73,7 @@ public void testDefaultTimeFormatValidate()
7373
throws InvalidArgumentException {
7474
final Object[] array = new Object[] { "18:00:00" };
7575
final List list = Arrays.asList(array);
76-
final Validator validator = DateValidator.getTimeInstance();
76+
final Validator validator = new DateValidator( new SimpleDateFormat("HH:mm:ss") );
7777

7878
validator.validate(list);
7979

@@ -87,7 +87,7 @@ public void testDefaultDateTimeFormatValidate()
8787
throws InvalidArgumentException {
8888
final Object[] array = new Object[] { "23-Jan-2003 18:00:00" };
8989
final List list = Arrays.asList(array);
90-
final Validator validator = DateValidator.getDateTimeInstance();
90+
final Validator validator = new DateValidator( new SimpleDateFormat("dd-MMM-yyyy HH:mm:ss") );
9191

9292
validator.validate(list);
9393

0 commit comments

Comments
 (0)